build/android/buildbot/bb_device_steps.py - Issue 891473007: Fix type error in bb_device_steps that causes test_report to crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 891473007: Fix type error in bb_device_steps that causes test_report to crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/buildbot/bb_device_steps.py

diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py

index e1858cef8b80da2f6e4c8be10d548a729a04e504..fc053d132f71eb60da21e52ae479ebed52d34502 100755

--- a/build/android/buildbot/bb_device_steps.py

+++ b/build/android/buildbot/bb_device_steps.py

@@ -340,13 +340,13 @@ def RunWebkitLayoutTests(options):

unexpected_passes, unexpected_failures, unexpected_flakes = (

_ParseLayoutTestResults(full_results))

if unexpected_failures:

- _PrintDashboardLink('failed', unexpected_failures,

+ _PrintDashboardLink('failed', unexpected_failures.keys(),

max_tests=25)

elif unexpected_passes:

- _PrintDashboardLink('unexpected passes', unexpected_passes,

+ _PrintDashboardLink('unexpected passes', unexpected_passes.keys(),

max_tests=10)

if unexpected_flakes:

- _PrintDashboardLink('unexpected flakes', unexpected_flakes,

+ _PrintDashboardLink('unexpected flakes', unexpected_flakes.keys(),

max_tests=10)

if exit_code == 0 and (unexpected_passes or unexpected_flakes):

« no previous file with comments | « no previous file | no next file » | no next file with comments »