Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: Source/core/loader/DocumentThreadableLoader.h

Issue 891263002: Prevent calling didReceiveData()/didFinishLoading() after didFailAccessControlCheck() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add FIXME. Use RELEASE_ASSERT. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/loader/DocumentThreadableLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/DocumentThreadableLoader.h
diff --git a/Source/core/loader/DocumentThreadableLoader.h b/Source/core/loader/DocumentThreadableLoader.h
index 9f44f3a56334aa6878bbb54a37db8795acbc3278..a99a62b3db0f162a591b3a574d796b16250642cf 100644
--- a/Source/core/loader/DocumentThreadableLoader.h
+++ b/Source/core/loader/DocumentThreadableLoader.h
@@ -104,7 +104,10 @@ class DocumentThreadableLoader final : public ThreadableLoader, private Resource
void loadActualRequest();
// Clears m_actualRequest and reports access control check failure to
// m_client.
- void handlePreflightFailure(const String& url, const String& errorDescription);
+ // Call handleAccessControlCheckFailure() instead of
+ // m_client->didFailAccessControlCheck() from other places in
tyoshino (SeeGerritForStatus) 2015/02/03 13:06:36 what does "other" here mean?
hiroshige 2015/02/03 13:11:39 I meant "anywhere outside handleAccessControlCheck
+ // DocumentThreadableLoader.
+ void handleAccessControlCheckFailure(const String& url, const String& errorDescription);
// Investigates the response for the preflight request. If successful,
// the actual request will be made later in handleSuccessfulFinish().
void handlePreflightResponse(const ResourceResponse&);
@@ -154,6 +157,8 @@ class DocumentThreadableLoader final : public ThreadableLoader, private Resource
// But this value is not the max number of total redirects allowed,
// because same-origin redirects are not counted here.
int m_corsRedirectLimit;
+
+ bool m_accessControlCheckFailed;
};
} // namespace blink
« no previous file with comments | « no previous file | Source/core/loader/DocumentThreadableLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698