Prevent calling didReceiveData()/didFinishLoading() after didFailAccessControlCheck()

Source/core/loader/DocumentThreadableLoader.h

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013, Intel Corporation
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 86 matching lines @@
         // about origin. Only for handling the initial load (including fallback
         // after consulting ServiceWorker).
         void dispatchInitialRequest(const ResourceRequest&);
         void makeCrossOriginAccessRequest(const ResourceRequest&);
         // Loads m_fallbackRequestForServiceWorker.
         void loadFallbackRequestForServiceWorker();
         // Loads m_actualRequest.
         void loadActualRequest();
         // Clears m_actualRequest and reports access control check failure to
         // m_client.
-        void handlePreflightFailure(const String& url, const String& errorDescription);
+        // Call handleAccessControlCheckFailure() instead of
+        // m_client->didFailAccessControlCheck() from other places in

[tyoshino (SeeGerritForStatus), 2015/02/03 13:06:36]

what does "other" here mean?

[hiroshige, 2015/02/03 13:11:39]

I meant "anywhere outside handleAccessControlCheckFailure".
This is not so helpful so removed "from other places".

+        // DocumentThreadableLoader.
+        void handleAccessControlCheckFailure(const String& url, const String& errorDescription);
         // Investigates the response for the preflight request. If successful,
         // the actual request will be made later in handleSuccessfulFinish().
         void handlePreflightResponse(const ResourceResponse&);
 
         void loadRequest(const ResourceRequest&, ResourceLoaderOptions);
         bool isAllowedRedirect(const KURL&) const;
         bool isAllowedByContentSecurityPolicy(const KURL&) const;
         // Returns DoNotAllowStoredCredentials
         // if m_forceDoNotAllowStoredCredentials is set. Otherwise, just
         // returns allowCredentials value of m_resourceLoaderOptions.
@@ skipping 29 matching lines @@
         HTTPHeaderMap m_simpleRequestHeaders; // stores simple request headers in case of a cross-origin redirect.
         Timer<DocumentThreadableLoader> m_timeoutTimer;
         double m_requestStartedSeconds; // Time an asynchronous fetch request is started
 
         // Max number of times that this DocumentThreadableLoader can follow
         // cross-origin redirects.
         // This is used to limit the number of redirects.
         // But this value is not the max number of total redirects allowed,
         // because same-origin redirects are not counted here.
         int m_corsRedirectLimit;
+
+        bool m_accessControlCheckFailed;
     };
 
 } // namespace blink
 
 #endif // DocumentThreadableLoader_h