Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 89123002: Move fIsOval from SkPath to SkPathRef (Closed)

Created:
7 years ago by robertphillips
Modified:
7 years ago
Reviewers:
bsalomon, caryclark, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

The old omnibus CL (https://codereview.chromium.org/25787002/) has gotten too far out of date. This calves off just the "fIsOval" portion. This patch also conflicts a bit with the post-skp-recapture-cleanup CL (https://codereview.chromium.org/88233003/) and, depending on which lands first, one or the other will require updating.

Patch Set 1 #

Patch Set 2 : Updated to add backwards compatibility from v16 to v15 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -66 lines) Patch
M include/core/SkPath.h View 1 5 chunks +8 lines, -4 lines 0 comments Download
M include/core/SkPathRef.h View 1 9 chunks +29 lines, -2 lines 0 comments Download
M include/core/SkPicture.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/core/SkPath.cpp View 1 15 chunks +12 lines, -46 lines 0 comments Download
M src/core/SkPathRef.cpp View 1 8 chunks +31 lines, -12 lines 0 comments Download
M src/core/SkPicture.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/PathTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
robertphillips
7 years ago (2013-11-26 22:23:50 UTC) #1
caryclark
as much as I understand this (which is not much!) this looks good to me
7 years ago (2013-11-27 01:09:41 UTC) #2
reed1
lgtm
7 years ago (2013-11-27 13:59:36 UTC) #3
bsalomon
On 2013/11/27 13:59:36, reed1 wrote: > lgtm lgtm, too.
7 years ago (2013-11-27 14:19:20 UTC) #4
robertphillips
committed as r12450
7 years ago (2013-12-02 23:55:42 UTC) #5
robertphillips
Reverted in r12452. Need to make the patch backwards compatible w.r.t. skps.
7 years ago (2013-12-03 00:24:43 UTC) #6
bsalomon
lgtm
7 years ago (2013-12-03 15:08:20 UTC) #7
robertphillips
7 years ago (2013-12-03 16:44:17 UTC) #8
Message was sent while issue was closed.
Relanded revised version as r12463

Powered by Google App Engine
This is Rietveld 408576698