Issue 89123002: Move fIsOval from SkPath to SkPathRef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 89123002: Move fIsOval from SkPath to SkPathRef (Closed)

Created:
7 years ago by robertphillips

Modified:
7 years ago

Reviewers:
bsalomon, caryclark, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

The old omnibus CL (https://codereview.chromium.org/25787002/) has gotten too far out of date. This calves off just the "fIsOval" portion. This patch also conflicts a bit with the post-skp-recapture-cleanup CL (https://codereview.chromium.org/88233003/) and, depending on which lands first, one or the other will require updating.

Patch Set 1 #

Patch Set 2 : Updated to add backwards compatibility from v16 to v15 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -66 lines)			Patch
M	include/core/SkPath.h	View	1	5 chunks	+8 lines, -4 lines	0 comments	Download
M	include/core/SkPathRef.h	View	1	9 chunks	+29 lines, -2 lines	0 comments	Download
M	include/core/SkPicture.h	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/core/SkPath.cpp	View	1	15 chunks	+12 lines, -46 lines	0 comments	Download
M	src/core/SkPathRef.cpp	View	1	8 chunks	+31 lines, -12 lines	0 comments	Download
M	src/core/SkPicture.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/PathTest.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

caryclark

as much as I understand this (which is not much!) this looks good to me

7 years ago (2013-11-27 01:09:41 UTC) #2

robertphillips

Reverted in r12452. Need to make the patch backwards compatible w.r.t. skps.

7 years ago (2013-12-03 00:24:43 UTC) #6

Message was sent while issue was closed.

Relanded revised version as r12463

Expand Messages | Collapse Messages