Delete RenderTextWin and RenderTextPango.

Delete RenderTextWin and RenderTextPango.

Windows, Linux, and Chrome OS use the cross-platform
RenderTextHarfBuzz class as of M40. Remove the
platform-specific RenderText implementations.

Also update chrome://flags so that only Mac users can
control whether RenderTextHarfBuzz is used. RenderTextMac is
still used there by default.

BUG=321868, 398885
Committed: https://crrev.com/a55b0115d7f52cd51a309eca15b08aa68d139455
Cr-Commit-Position: refs/heads/master@{#314242}

[Daniel Erat, 2015-02-02 18:03:15]

derat@chromium.org changed reviewers:
+ ckocagil@chromium.org, msw@chromium.org

[Daniel Erat, 2015-02-02 18:03:15]

let me know what you think about landing this now that M40 has shipped on all
platforms! i'd like to drop RenderTextPango so i can kill off PlatformFontPango
as well (http://crbug.com/398885).

[msw, 2015-02-02 22:52:55]

lgtm with nits.

https://codereview.chromium.org/891013003/diff/80001/ui/gfx/render_text_unitt...
File ui/gfx/render_text_unittest.cc (left):

https://codereview.chromium.org/891013003/diff/80001/ui/gfx/render_text_unitt...
ui/gfx/render_text_unittest.cc:2065:
render_text->SetText(WideToUTF16(L"x\x25B6y"));
I wonder if we could preserve a similar test for HarfBuzz...
(ensure that characters of unusual code blocks are drawn correctly)

https://codereview.chromium.org/891013003/diff/80001/ui/gfx/switches.cc
File ui/gfx/switches.cc (right):

https://codereview.chromium.org/891013003/diff/80001/ui/gfx/switches.cc#newco...
ui/gfx/switches.cc:26: // Enables the HarfBuzz port of RenderText on Mac.
nit: Maybe mention that RenderTextHarfBuzz is already used on Mac for text
editing?

[Daniel Erat, 2015-02-02 23:10:31]

thanks (and welcome back)!

https://codereview.chromium.org/891013003/diff/80001/ui/gfx/render_text_unitt...
File ui/gfx/render_text_unittest.cc (left):

https://codereview.chromium.org/891013003/diff/80001/ui/gfx/render_text_unitt...
ui/gfx/render_text_unittest.cc:2065:
render_text->SetText(WideToUTF16(L"x\x25B6y"));
On 2015/02/02 22:52:55, msw wrote:
> I wonder if we could preserve a similar test for HarfBuzz...
> (ensure that characters of unusual code blocks are drawn correctly)

it's collapsed, but it looks like we already have an identical harfbuzz-specific
test: see HarfBuzz_BreakRunsByUnicodeBlocks on line 2139.

https://codereview.chromium.org/891013003/diff/80001/ui/gfx/switches.cc
File ui/gfx/switches.cc (right):

https://codereview.chromium.org/891013003/diff/80001/ui/gfx/switches.cc#newco...
ui/gfx/switches.cc:26: // Enables the HarfBuzz port of RenderText on Mac.
On 2015/02/02 22:52:55, msw wrote:
> nit: Maybe mention that RenderTextHarfBuzz is already used on Mac for text
> editing?

Done.

[Daniel Erat, 2015-02-02 23:12:46]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2015-02-02 23:13:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/891013003/100001

[commit-bot: I haz the power, 2015-02-03 01:59:36]

Committed patchset #6 (id:100001)

[ckocagil, 2015-02-03 02:00:26]

\o/

[commit-bot: I haz the power, 2015-02-03 02:00:29]

Patchset 6 (id:??) landed as
https://crrev.com/a55b0115d7f52cd51a309eca15b08aa68d139455
Cr-Commit-Position: refs/heads/master@{#314242}