Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 890893006: [Cronet] HistogramManager now ensures that StatisticsRecorder is initialized. (Closed)

Created:
5 years, 10 months ago by mef
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] HistogramManager now ensures that StatisticsRecorder is initialized. BUG=441466 Committed: https://crrev.com/7b7cfa4eaac31e05f5b9a5b6b142507f8ec3d5dc Cr-Commit-Position: refs/heads/master@{#313997}

Patch Set 1 #

Patch Set 2 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M components/cronet/android/histogram_manager.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/HistogramManager.java View 2 chunks +3 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HistogramManagerTest.java View 3 chunks +5 lines, -0 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
mef
5 years, 10 months ago (2015-01-30 19:58:42 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-01-30 20:08:57 UTC) #3
xunjieli
On 2015/01/30 20:08:57, Alexei Svitkine wrote: > lgtm lgtm
5 years, 10 months ago (2015-01-30 20:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890893006/1
5 years, 10 months ago (2015-01-30 20:31:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/18958) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/54006) ios_rel_device_ng ...
5 years, 10 months ago (2015-01-30 20:35:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890893006/20001
5 years, 10 months ago (2015-01-30 21:02:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 21:41:24 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 21:43:21 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b7cfa4eaac31e05f5b9a5b6b142507f8ec3d5dc
Cr-Commit-Position: refs/heads/master@{#313997}

Powered by Google App Engine
This is Rietveld 408576698