components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HistogramManagerTest.java - Issue 890893006: [Cronet] HistogramManager now ensures that StatisticsRecorder is initialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HistogramManagerTest.java

Issue 890893006: [Cronet] HistogramManager now ensures that StatisticsRecorder is initialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/HistogramManager.java ('k') | components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HistogramManagerTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HistogramManagerTest.java b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HistogramManagerTest.java

index 4a20c6ac11039c61739e12d183dd82e0e740463c..9d75b4e008d0b152d76549a0ff01f3299afe7f56 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HistogramManagerTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HistogramManagerTest.java

@@ -9,6 +9,8 @@ import android.test.suitebuilder.annotation.SmallTest;

import org.chromium.base.test.util.Feature;

import org.chromium.net.UrlRequest;

+import java.util.Arrays;

/**

* Test HistogramManager.

@@ -23,6 +25,7 @@ public class HistogramManagerTest extends CronetTestBase {

public void testHistogramManager() throws Exception {

mActivity = launchCronetTestApp();

byte delta1[] = mActivity.mHistogramManager.getHistogramDeltas();

+ assertTrue(delta1.length != 0);

TestUrlRequestListener listener = new TestUrlRequestListener();

UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(

@@ -30,5 +33,7 @@ public class HistogramManagerTest extends CronetTestBase {

urlRequest.start();

listener.blockForDone();

byte delta2[] = mActivity.mHistogramManager.getHistogramDeltas();

+ assertTrue(delta2.length != 0);

+ assertFalse(Arrays.equals(delta1, delta2));

}