Issue 890893002: Support generation of tearoffs for instance methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 890893002: Support generation of tearoffs for instance methods. (Closed)

Created:
5 years, 10 months ago by herhut

Modified:
5 years, 10 months ago

Reviewers:
floitsch, zarah

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Support generation of tearoffs for instance methods. BUG= superseded by https://codereview.chromium.org/895083002/

Patch Set 1 #

Patch Set 2 : unbreak old backend #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -25 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart	View		7 chunks	+34 lines, -19 lines	2 comments	Download
	M	sdk/lib/_internal/compiler/js_lib/js_helper.dart	View	1	4 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

herhut

WIP. It passes basic tests but I have not fully tested it. Requires all of ...

5 years, 10 months ago (2015-01-30 13:04:43 UTC) #3

floitsch

5 years, 10 months ago (2015-01-30 22:08:39 UTC) #4

https://codereview.chromium.org/890893002/diff/40001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/890893002/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:446: return
[js.string(stub.name), callName, method.code];
This should be `stub.code`.

https://codereview.chromium.org/890893002/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:599:
parseFunctionDescriptor(prototype, descriptor[i], descriptor[i+1]);
Don't remove the spaces of "i + 1".

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages