update example

First cut at cleaning up Sergio's example code and moving some common code to SkWindow.

Eventually, this will be moved to be a peer of SampleApp so it is compiled by the bots to avoid future bit rot.

Also ignore XCode auto-generated flag in CommandLineFlags, and remove the unused multiple-example part.

Committed: https://skia.googlesource.com/skia/+/c8fcafb3f0d152fb92465451bdb2e4bd3ef37222

[caryclark, 2015-01-30 18:53:13]

caryclark@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[bsalomon, 2015-01-30 19:19:13]

https://codereview.chromium.org/890873003/diff/30001/experimental/SkiaExample...
File experimental/SkiaExamples/SkExample.h (right):

https://codereview.chromium.org/890873003/diff/30001/experimental/SkiaExample...
experimental/SkiaExamples/SkExample.h:48: virtual ~SkExampleWindow();
~SkExampleWindow() SK_OVERRIDE?

https://codereview.chromium.org/890873003/diff/30001/experimental/SkiaExample...
experimental/SkiaExamples/SkExample.h:56: static void release_storage(void*
pixels, void* context) {
ReleaseStorage?

https://codereview.chromium.org/890873003/diff/30001/src/views/SkWindow.cpp
File src/views/SkWindow.cpp (right):

https://codereview.chromium.org/890873003/diff/30001/src/views/SkWindow.cpp#n...
src/views/SkWindow.cpp:358: desc.fSampleCnt = attachmentInfo.fSampleCount;
The division of labor for creating a GL context, a GrContext, and a
GrRenderTarget* for the window's surface has evolved quite oddly. I think this
mostly has to do with Ganesh originally being born outside of Skia and Skia
wanting to use GL without depending on Ganesh, but being able to interop with
Ganesh when they were compiled together. Of course, that division is long gone.

What if Sk(OS)Window::attach() created all three and kept a ref to the GrContext
and GrRenderTarget? We might be able to eliminate AttachmentInfo and the need to
query the current FBO binding using glGetIntegerv. It could just wrap the
window's surface with a GrRenderTarget while creating the GL context.

[caryclark, 2015-01-30 19:55:28]

https://codereview.chromium.org/890873003/diff/30001/experimental/SkiaExample...
File experimental/SkiaExamples/SkExample.h (right):

https://codereview.chromium.org/890873003/diff/30001/experimental/SkiaExample...
experimental/SkiaExamples/SkExample.h:48: virtual ~SkExampleWindow();
On 2015/01/30 19:19:12, bsalomon wrote:
> ~SkExampleWindow() SK_OVERRIDE?

Done.

https://codereview.chromium.org/890873003/diff/30001/experimental/SkiaExample...
experimental/SkiaExamples/SkExample.h:56: static void release_storage(void*
pixels, void* context) {
On 2015/01/30 19:19:12, bsalomon wrote:
> ReleaseStorage?

The whole function is unused so I deleted it.

https://codereview.chromium.org/890873003/diff/30001/src/views/SkWindow.cpp
File src/views/SkWindow.cpp (right):

https://codereview.chromium.org/890873003/diff/30001/src/views/SkWindow.cpp#n...
src/views/SkWindow.cpp:358: desc.fSampleCnt = attachmentInfo.fSampleCount;
On 2015/01/30 19:19:12, bsalomon wrote:
> The division of labor for creating a GL context, a GrContext, and a
> GrRenderTarget* for the window's surface has evolved quite oddly. I think this
> mostly has to do with Ganesh originally being born outside of Skia and Skia
> wanting to use GL without depending on Ganesh, but being able to interop with
> Ganesh when they were compiled together. Of course, that division is long
gone.
> 
> What if Sk(OS)Window::attach() created all three and kept a ref to the
GrContext
> and GrRenderTarget? We might be able to eliminate AttachmentInfo and the need
to
> query the current FBO binding using glGetIntegerv. It could just wrap the
> window's surface with a GrRenderTarget while creating the GL context.
> 
> 

Sounds like a great idea, but refactoring SkOSWindow::attach() looks hard, or at
least worthy of its own CL. Each platform's implementation has little in common
-- not even C++.

[bsalomon, 2015-01-30 19:58:36]

On 2015/01/30 19:55:28, caryclark wrote:
>
https://codereview.chromium.org/890873003/diff/30001/experimental/SkiaExample...
> File experimental/SkiaExamples/SkExample.h (right):
> 
>
https://codereview.chromium.org/890873003/diff/30001/experimental/SkiaExample...
> experimental/SkiaExamples/SkExample.h:48: virtual ~SkExampleWindow();
> On 2015/01/30 19:19:12, bsalomon wrote:
> > ~SkExampleWindow() SK_OVERRIDE?
> 
> Done.
> 
>
https://codereview.chromium.org/890873003/diff/30001/experimental/SkiaExample...
> experimental/SkiaExamples/SkExample.h:56: static void release_storage(void*
> pixels, void* context) {
> On 2015/01/30 19:19:12, bsalomon wrote:
> > ReleaseStorage?
> 
> The whole function is unused so I deleted it.
> 
> https://codereview.chromium.org/890873003/diff/30001/src/views/SkWindow.cpp
> File src/views/SkWindow.cpp (right):
> 
>
https://codereview.chromium.org/890873003/diff/30001/src/views/SkWindow.cpp#n...
> src/views/SkWindow.cpp:358: desc.fSampleCnt = attachmentInfo.fSampleCount;
> On 2015/01/30 19:19:12, bsalomon wrote:
> > The division of labor for creating a GL context, a GrContext, and a
> > GrRenderTarget* for the window's surface has evolved quite oddly. I think
this
> > mostly has to do with Ganesh originally being born outside of Skia and Skia
> > wanting to use GL without depending on Ganesh, but being able to interop
with
> > Ganesh when they were compiled together. Of course, that division is long
> gone.
> > 
> > What if Sk(OS)Window::attach() created all three and kept a ref to the
> GrContext
> > and GrRenderTarget? We might be able to eliminate AttachmentInfo and the
need
> to
> > query the current FBO binding using glGetIntegerv. It could just wrap the
> > window's surface with a GrRenderTarget while creating the GL context.
> > 
> > 
> 
> Sounds like a great idea, but refactoring SkOSWindow::attach() looks hard, or
at
> least worthy of its own CL. Each platform's implementation has little in
common
> -- not even C++.

Ok, I thought that was a likely response when I wrote the comment :) lgtm.

[reed1, 2015-01-30 20:21:01]

lgtm

[caryclark, 2015-01-30 20:30:08]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2015-01-30 20:30:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/890873003/70001

[commit-bot: I haz the power, 2015-01-30 20:37:06]

Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/c8fcafb3f0d152fb92465451bdb2e4bd3ef37222