Issue 890773004: win: Add NoImportLibrary flag for ninja generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 890773004: win: Add NoImportLibrary flag for ninja generator (Closed)

Created:
5 years, 10 months ago by scottmg

Modified:
5 years, 10 months ago

Reviewers:
grt (UTC plus 2)

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

win: Add NoImportLibrary flag for ninja generator This adds a flag that tells ninja not to expect an import library to be generated. This is only needed very rarely in the case of DLLs that have no exported symbols. There is no corresponding functionality in the msvs generator, so the test and functionality are ninja generator-only. R=grt@chromium.org BUG=gyp:397, chromium:451499 Committed: https://code.google.com/p/gyp/source/detail?r=2030

Patch Set 1 #

Patch Set 2 : . #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -3 lines)			Patch
M	pylib/gyp/generator/ninja.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pylib/gyp/msvs_emulation.py	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	test/win/gyptest-link-noimportlib.py	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
A +	test/win/importlib/dll_no_exports.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	test/win/importlib/noimplib.gyp	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

grt (UTC plus 2)

lgtm to the extent that i remember anything about this. :-)

5 years, 10 months ago (2015-01-30 14:35:39 UTC) #3

scottmg

5 years, 10 months ago (2015-01-30 20:24:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:40001) manually as 2030 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages