pylib/gyp/generator/ninja.py - Issue 890773004: win: Add NoImportLibrary flag for ninja generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/ninja.py

Issue 890773004: win: Add NoImportLibrary flag for ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: . Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/generator/ninja.py

diff --git a/pylib/gyp/generator/ninja.py b/pylib/gyp/generator/ninja.py

index 0c7ce547c8862082cb0b0a07c4bdad3e04a294c6..5407795b3ba50228d0a083fa3202cac4ee2ee064 100644

--- a/pylib/gyp/generator/ninja.py

+++ b/pylib/gyp/generator/ninja.py

@@ -1217,7 +1217,8 @@ class NinjaWriter(object):

gyp.common.EncodePOSIXShellArgument(link_file_list)))

if self.flavor == 'win':

extra_bindings.append(('binary', output))

- if '/NOENTRY' not in ldflags:

+ if ('/NOENTRY' not in ldflags and

+ not self.msvs_settings.GetNoImportLibrary(config_name)):

self.target.import_lib = output + '.lib'

extra_bindings.append(('implibflag',

'/IMPLIB:%s' % self.target.import_lib))

« no previous file with comments | « no previous file | pylib/gyp/msvs_emulation.py » ('j') | no next file with comments »