Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 890723004: Allow setting runtime-enabled features from a string. (Closed)

Created:
5 years, 10 months ago by jbroman
Modified:
5 years, 10 months ago
Reviewers:
pdr., chrishtr, eseidel
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Allow setting runtime-enabled features from a string. This provides the plumbing necessary for content/ to provide flags to generally enable and disable simple runtime-enabled features. Some features will still require more complicated logic, but this should make the 90% case easier. The Chromium-side CL is: https://codereview.chromium.org/898483004/ BUG=454504 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M Source/build/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl View 2 chunks +17 lines, -0 lines 0 comments Download
M Source/build/scripts/templates/RuntimeEnabledFeatures.h.tmpl View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbroman
If this LGTY, I'll send the Chromium-side CL for review. Ultimately, things that need Chromium ...
5 years, 10 months ago (2015-02-02 21:25:40 UTC) #2
chrishtr
lgtm
5 years, 10 months ago (2015-02-02 21:36:01 UTC) #3
jbroman
On 2015/02/02 21:36:01, chrishtr wrote: > lgtm waiting for approval on chromium CL before landing
5 years, 10 months ago (2015-02-02 21:44:28 UTC) #4
pdr.
This is cool! +eseidel just FYI :)
5 years, 10 months ago (2015-02-02 22:27:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890723004/1
5 years, 10 months ago (2015-02-04 15:04:39 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 16:03:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189510

Powered by Google App Engine
This is Rietveld 408576698