Support replaceAll for regexps.

Support replaceAll for regexps.

TBR

Committed: https://code.google.com/p/dart/source/detail?r=2441

[Jennifer Messerly, 2011-12-14 20:36:56]

lgtm

http://codereview.chromium.org/8907042/diff/1/frog/lib/corelib_impl.dart
File frog/lib/corelib_impl.dart (right):

http://codereview.chromium.org/8907042/diff/1/frog/lib/corelib_impl.dart#newc...
frog/lib/corelib_impl.dart:289: * Note that the returned RegExp disobeys the
normal API in that it maintains
nice refactoring :)

out of curiosity--what does it mean that the returned RegExp disobeys the normal
api? Is it a bug we should fix, or an implementation note?

http://codereview.chromium.org/8907042/diff/1/frog/lib/string_implementation....
File frog/lib/string_implementation.dart (right):

http://codereview.chromium.org/8907042/diff/1/frog/lib/string_implementation....
frog/lib/string_implementation.dart:54: for (var match in from.allMatches(this))
{
Thanks for making this more consistent with the rest of the frog code!

Interesting style question though: I've noticed that I'm using the "for (var
match in ...)" style. I'm not sure why I was doing that, other than old C#
habits. I wonder if we should switch to the "for (match in ..." style? Anyway
not something to worry about in the short term :)

[nweiz, 2011-12-14 21:39:21]

http://codereview.chromium.org/8907042/diff/1/frog/lib/corelib_impl.dart
File frog/lib/corelib_impl.dart (right):

http://codereview.chromium.org/8907042/diff/1/frog/lib/corelib_impl.dart#newc...
frog/lib/corelib_impl.dart:289: * Note that the returned RegExp disobeys the
normal API in that it maintains
On 2011/12/14 20:36:56, John Messerly wrote:
> nice refactoring :)
> 
> out of curiosity--what does it mean that the returned RegExp disobeys the
normal
> api? Is it a bug we should fix, or an implementation note?

It's an implementation note. When a JS regexp has the "g" flag set and it's run
against the same string multiple times, it searches further into the string each
time. This is intended, and it's how we implement AllMatchesIterator.