Support replaceAll for regexps.

frog/lib/corelib_impl.dart

Index: frog/lib/corelib_impl.dart
diff --git a/frog/lib/corelib_impl.dart b/frog/lib/corelib_impl.dart
index 0ed43dcc0218047815e2c9a2235c692b6ccca3dd..2c7bc003da2714b8774bf67c13517cc3d7e81486 100644
--- a/frog/lib/corelib_impl.dart
+++ b/frog/lib/corelib_impl.dart
@@ -279,6 +279,18 @@ class JSSyntaxRegExp implements RegExp {
   }
 
   Iterable<Match> allMatches(String str) => new _AllMatchesIterable(this, str);
+
+  /**
+   * Returns a new RegExp with the same pattern as this one and with the
+   * "global" flag set. This allows us to match this RegExp against a string
+   * multiple times, to support things like [allMatches] and
+   * [String.replaceAll].
+   *
+   * Note that the returned RegExp disobeys the normal API in that it maintains

[Jennifer Messerly, 2011/12/14 20:36:56]

nice refactoring :)

out of curiosity--what does it mean that the returned RegExp disobeys the normal
api? Is it a bug we should fix, or an implementation note?

[nweiz, 2011/12/14 21:39:21]

It's an implementation note. When a JS regexp has the "g" flag set and it's run
against the same string multiple times, it searches further into the string each
time. This is intended, and it's how we implement AllMatchesIterator.

+   * state about the location of the last match.
+   */
+  JSSyntaxRegExp get _global() => new JSSyntaxRegExp._create(pattern,
+      'g' + (multiLine ? 'm' : '') + (ignoreCase ? 'i' : ''));
 }
 
 class MatchImplementation implements Match {
@@ -323,13 +335,8 @@ class _AllMatchesIterator implements Iterator<Match> {
   Match _next;
   bool _done;
 
-  _AllMatchesIterator(RegExp re, String this._str)
-    : _done = false,
-      _re = new JSSyntaxRegExp._create(re.pattern,
-        // Create a new RegExp with the "global" flag set so we can use it to
-        // iterate over multiple matches. Note that this will make the RegExp
-        // disobey the normal API.
-        'g' + (re.multiLine ? 'm' : '') + (re.ignoreCase ? 'i' : ''));
+  _AllMatchesIterator(JSSyntaxRegExp re, String this._str)
+    : _done = false, _re = re._global;
 
   Match next() {
     if (!hasNext()) {