Issue 890433003: Revert of Add device space "nudge" to gpu draws

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 890433003: Revert of Add device space "nudge" to gpu draws (Closed)

Created:
5 years, 10 months ago by robertphillips

Modified:
5 years, 10 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Add device space "nudge" to gpu draws (patchset #5 id:70001 of https://codereview.chromium.org/877473005/) Reason for revert: Chrome pixel test :( Original issue's description: > Add device space "nudge" to gpu draws > > This CL nudges all the GPU draws and clips slightly to match raster's round behavior for BW draws. We assume the effect will be negligible and do it for AA draws too. > > BUG=423834 > > Committed: https://skia.googlesource.com/skia/+/2d55d07501c56310f97d2092d789a2bc9fa01b78 TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=423834 Committed: https://skia.googlesource.com/skia/+/9cc2f2613a4fa27de2c6c79830433867c72d8cd5

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -88 lines)			Patch
M	samplecode/SampleClipDrawMatch.cpp	View	7 chunks	+59 lines, -66 lines	0 comments	Download
M	src/core/SkClipStack.cpp	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/gpu/effects/GrConvexPolyEffect.cpp	View	3 chunks	+7 lines, -16 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp	View	1 chunk	+4 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of Add device space "nudge" to gpu draws

5 years, 10 months ago (2015-01-29 01:36:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890433003/1

5 years, 10 months ago (2015-01-29 01:37:25 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-01-29 01:37:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9cc2f2613a4fa27de2c6c79830433867c72d8cd5