extensions/browser/guest_view/web_view/web_view_guest.h - Issue 890183002: Allow Signin page to open other chrome:// URLs if login content in <webview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 890183002: Allow Signin page to open other chrome:// URLs if login content in <webview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/platform_apps/web_view/simple/main.js ('K') | « extensions/browser/guest_view/test_guest_view_manager.h ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_guest.h

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h

index 537f30118cecf7cd23f7eaa1bea84320b11db690..21c0ff3a3530a3bd45620f38f518ba0cd1c9b1d9 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.h

+++ b/extensions/browser/guest_view/web_view/web_view_guest.h

@@ -288,7 +288,7 @@ class WebViewGuest : public GuestView<WebViewGuest>,

void LoadURLWithParams(const GURL& url,

Charlie Reis 2015/02/19 22:56:28 nit: Let's document what force_navigation means, s

Fady Samuel 2015/02/20 00:33:06 Done.

const content::Referrer& referrer,

ui::PageTransition transition_type,

- content::WebContents* web_contents);

+ bool force_navigation);

void RequestNewWindowPermission(

WindowOpenDisposition disposition,