Allow Signin page to open other chrome:// URLs if login content in <webview>

extensions/browser/guest_view/web_view/web_view_guest.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_GUEST_H_
 #define EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_GUEST_H_
 
 #include <vector>
 
 #include "base/observer_list.h"
@@ skipping 267 matching lines @@
 
   // Called when a redirect notification occurs.
   void LoadRedirect(const GURL& old_url,
                     const GURL& new_url,
                     bool is_top_level);
 
   void PushWebViewStateToIOThread();
   static void RemoveWebViewStateFromIOThread(
       content::WebContents* web_contents);
 
   void LoadURLWithParams(const GURL& url,

[Charlie Reis, 2015/02/19 22:56:28]

nit: Let's document what force_navigation means, since it's not obvious.

[Fady Samuel, 2015/02/20 00:33:06]

Done.

                          const content::Referrer& referrer,
                          ui::PageTransition transition_type,
-                         content::WebContents* web_contents);
+                         bool force_navigation);
 
   void RequestNewWindowPermission(
       WindowOpenDisposition disposition,
       const gfx::Rect& initial_bounds,
       bool user_gesture,
       content::WebContents* new_contents);
 
   // Requests resolution of a potentially relative URL.
   GURL ResolveURL(const std::string& src);
 
@@ skipping 70 matching lines @@
   // This is used to ensure pending tasks will not fire after this object is
   // destroyed.
   base::WeakPtrFactory<WebViewGuest> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewGuest);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_GUEST_H_