ui/views/accessibility/ax_widget_obj_wrapper.cc - Issue 890013006: Reland #2: Ensure WebView notifies desktop automation on creation, destruction, and change Original

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/accessibility/ax_widget_obj_wrapper.cc

Issue 890013006: Reland #2: Ensure WebView notifies desktop automation on creation, destruction, and change Original (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One more potential case. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/accessibility/ax_widget_obj_wrapper.cc

diff --git a/ui/views/accessibility/ax_widget_obj_wrapper.cc b/ui/views/accessibility/ax_widget_obj_wrapper.cc

index 36a3143e365ec96b9aca5704ef49d7fe46c15c42..44fcfa8920276546617e7c713408dc52668a4f75 100644

--- a/ui/views/accessibility/ax_widget_obj_wrapper.cc

+++ b/ui/views/accessibility/ax_widget_obj_wrapper.cc

@@ -17,8 +17,10 @@ AXWidgetObjWrapper::AXWidgetObjWrapper(Widget* widget) : widget_(widget) {

}

AXWidgetObjWrapper::~AXWidgetObjWrapper() {

- widget_->RemoveObserver(this);

- widget_->RemoveRemovalsObserver(this);

+ if (!AXAuraObjCache::GetInstance()->is_destroying()) {

+ widget_->RemoveObserver(this);

+ widget_->RemoveRemovalsObserver(this);

+ }

widget_ = NULL;

}

« no previous file with comments | « ui/views/accessibility/ax_aura_obj_cache.cc ('k') | ui/views/controls/webview/webview.h » ('j') | no next file with comments »