ui/views/accessibility/ax_aura_obj_cache.cc - Issue 890013006: Reland #2: Ensure WebView notifies desktop automation on creation, destruction, and change Original

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/accessibility/ax_aura_obj_cache.cc

Issue 890013006: Reland #2: Ensure WebView notifies desktop automation on creation, destruction, and change Original (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One more potential case. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/accessibility/ax_aura_obj_cache.cc

diff --git a/ui/views/accessibility/ax_aura_obj_cache.cc b/ui/views/accessibility/ax_aura_obj_cache.cc

index ae2df2068abc40e3aa5a889555e934c8a7fccb7e..05f18686fc4154e7b4c22f090c63b620325662c8 100644

--- a/ui/views/accessibility/ax_aura_obj_cache.cc

+++ b/ui/views/accessibility/ax_aura_obj_cache.cc

@@ -76,10 +76,11 @@ void AXAuraObjCache::Remove(int32 id) {

delete obj;

}

-AXAuraObjCache::AXAuraObjCache() : current_id_(1) {

+AXAuraObjCache::AXAuraObjCache() : current_id_(1), is_destroying_(false) {

}

AXAuraObjCache::~AXAuraObjCache() {

+ is_destroying_ = true;

STLDeleteContainerPairSecondPointers(cache_.begin(), cache_.end());

cache_.clear();

}

« no previous file with comments | « ui/views/accessibility/ax_aura_obj_cache.h ('k') | ui/views/accessibility/ax_widget_obj_wrapper.cc » ('j') | no next file with comments »