sky/engine/bindings/core/v8/V8Binding.h - Issue 889823002: Remove TRACE_EVENT indirection through blink::Platform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/V8Binding.h

Issue 889823002: Remove TRACE_EVENT indirection through blink::Platform (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/core/v8/V8Binding.h

diff --git a/sky/engine/bindings/core/v8/V8Binding.h b/sky/engine/bindings/core/v8/V8Binding.h

index f98fd40d6d90283d92fd5cf4c2457c554901f58e..ba4697631a5dd2dd01f07378b1b4dbebccb845da 100644

--- a/sky/engine/bindings/core/v8/V8Binding.h

+++ b/sky/engine/bindings/core/v8/V8Binding.h

@@ -746,9 +746,6 @@ private:

RefPtr<ScriptState> m_scriptState;

};

-void GetDevToolsFunctionInfo(v8::Handle<v8::Function>, v8::Isolate*, int& scriptId, String& resourceName, int& lineNumber);

-PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(ExecutionContext*, v8::Handle<v8::Function>, v8::Isolate*);

class V8RethrowTryCatchScope final {

public:

explicit V8RethrowTryCatchScope(v8::TryCatch& block) : m_block(block) { }