Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889693003: dart2js: Use stub instances when generating ParameterStubs (adapterStubMethods). (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Use stub instances when generating ParameterStubs (adapterStubMethods). Obsoleted by https://codereview.chromium.org/886053004/ and zarah's CL: https://codereview.chromium.org/887853004/

Patch Set 1 #

Patch Set 2 : Remove unused field. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -122 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 1 2 chunks +25 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart View 6 chunks +147 lines, -109 lines 1 comment Download
M pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
@zarah: I merged in your CL (https://chromiumcodereview.appspot.com/890583003/)
5 years, 10 months ago (2015-01-29 23:49:53 UTC) #2
floitsch
https://codereview.chromium.org/889693003/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right): https://codereview.chromium.org/889693003/diff/20001/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart#newcode185 pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:185: List<AdapterStubMethod> generateParameterStubs(FunctionElement member, I'm sorry, but I couldn't resist ...
5 years, 10 months ago (2015-01-30 00:00:14 UTC) #3
zarah
5 years, 10 months ago (2015-01-30 10:02:32 UTC) #4 
I uploaded the change I was working on yesterday :
https://codereview.chromium.org/887853004/

It touches the same things as this cl so we should probably talk about how to
merge them.

Powered by Google App Engine
This is Rietveld 408576698