Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 889653006: Revert of Roll ANGLE 592ab9dd9..38832d179d. (Closed)

Created:
5 years, 10 months ago by waffles
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dewittj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll ANGLE 592ab9dd9..38832d179d. (patchset #1 id:1 of https://codereview.chromium.org/912423002/) Reason for revert: Breaks Win8 GN build: http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4638 FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/angle/src/libANGLE/renderer/d3d/libANGLE.ProgramD3D.obj.rsp /c ../../third_party/angle/src/libANGLE/renderer/d3d/ProgramD3D.cpp /Foobj/third_party/angle/src/libANGLE/renderer/d3d/libANGLE.ProgramD3D.obj /Fdobj/third_party/angle/libANGLE_cc.pdb e:\b\depot_tools\win_toolchain\vs2013_files\vc\include\concrt.h(313) : error C2220: warning treated as error - no 'object' file generated e:\b\depot_tools\win_toolchain\vs2013_files\vc\include\concrt.h(313) : warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc Original issue's description: > Roll ANGLE 592ab9dd9..38832d179d. > > https://chromium.googlesource.com/angle/angle/+log/592ab9dd9..38832d179d > > BUG=450257, 447419, 452587, 453543 > > Committed: https://crrev.com/3d2f2ff2b1527148d12cd92177951516ae9d1ede > Cr-Commit-Position: refs/heads/master@{#315862} TBR=bajones@chromium.org,kbr@chromium.org,zmo@chromium.org,jmadill@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450257, 447419, 452587, 453543 Committed: https://crrev.com/f46813fc5d985fccb715e278a984ad7348f11b3a Cr-Commit-Position: refs/heads/master@{#315879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
waffles
Created Revert of Roll ANGLE 592ab9dd9..38832d179d.
5 years, 10 months ago (2015-02-12 00:07:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889653006/1
5 years, 10 months ago (2015-02-12 00:09:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 00:14:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f46813fc5d985fccb715e278a984ad7348f11b3a Cr-Commit-Position: refs/heads/master@{#315879}
5 years, 10 months ago (2015-02-12 00:15:08 UTC) #4
Ken Russell (switch to Gerrit)
@jmadill: let me know if you have any difficulty re-landing this ANGLE roll. I don't ...
5 years, 10 months ago (2015-02-12 12:08:12 UTC) #5
Jamie Madill
5 years, 10 months ago (2015-02-12 14:33:31 UTC) #6
Message was sent while issue was closed.
On 2015/02/12 12:08:12, Ken Russell wrote:
> @jmadill: let me know if you have any difficulty re-landing this ANGLE roll. I
> don't know who's pulling in concrt.h and the associated try/catch block in the
> operator new.

I have a feeling it was Austin's patch here:

https://chromium-review.googlesource.com/244860

We ran in to the same error on another bot, but we fixed it. I'll give him a
ping and hopefully we can figure it out.

Powered by Google App Engine
This is Rietveld 408576698