Add support for passing bitmaps to Android infobars

Add support for passing bitmaps to Android infobars

Native infobars are already capable of choosing between
a resource and a Bitmap for the infobar icon.  Pass this
information through to the Java side so the UI widgets
can also display the Bitmap version of the icon.

BUG=453170
Committed: https://crrev.com/7931ccb5292f20375145443b5c3a9a547a334fbd
Cr-Commit-Position: refs/heads/master@{#314183}

[gone, 2015-01-31 02:35:48]

dfalcantara@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2015-02-02 17:01:50]

https://codereview.chromium.org/889613003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBarDelegate.java
(right):

https://codereview.chromium.org/889613003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBarDelegate.java:31:
* @param bitmap Bitmap to use if there is no equivalent Java resource.
"... Java resource for enumeratedIconId"

https://codereview.chromium.org/889613003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java
(right):

https://codereview.chromium.org/889613003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java:174:
// Set up the icon.
How about:

    if (iconResourceId != 0 || iconBitmap != null) {
        mIconView = new ImageView(context);
        if (iconResourceId != 0) {
            mIconView.setImageResource(iconResourceId);
        } else {
            mIconView.setImageBitmap(iconBitmap);
        }
        // setLayoutParams, etc
    }

That seems better than having a 0x0 ImageView in the case where there's no icon,
which may confuse TalkBack and developers

[gone, 2015-02-02 18:09:20]

https://chromiumcodereview.appspot.com/889613003/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBarDelegate.java
(right):

https://chromiumcodereview.appspot.com/889613003/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBarDelegate.java:31:
* @param bitmap Bitmap to use if there is no equivalent Java resource.
On 2015/02/02 17:01:50, newt wrote:
> "... Java resource for enumeratedIconId"

Done.

https://chromiumcodereview.appspot.com/889613003/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java
(right):

https://chromiumcodereview.appspot.com/889613003/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java:174:
// Set up the icon.
On 2015/02/02 17:01:50, newt wrote:
> How about:
> 
>     if (iconResourceId != 0 || iconBitmap != null) {
>         mIconView = new ImageView(context);
>         if (iconResourceId != 0) {
>             mIconView.setImageResource(iconResourceId);
>         } else {
>             mIconView.setImageBitmap(iconBitmap);
>         }
>         // setLayoutParams, etc
>     }
> 
> That seems better than having a 0x0 ImageView in the case where there's no
icon,
> which may confuse TalkBack and developers

Done.

[newt (away), 2015-02-02 18:20:38]

lgtm

[gone, 2015-02-02 18:21:04]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-02-02 18:22:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/889613003/20001

[commit-bot: I haz the power, 2015-02-02 20:39:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-02 20:40:46]

Patchset 2 (id:??) landed as
https://crrev.com/7931ccb5292f20375145443b5c3a9a547a334fbd
Cr-Commit-Position: refs/heads/master@{#314183}