chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java - Issue 889613003: Add support for passing bitmaps to Android infobars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

Issue 889613003: Add support for passing bitmaps to Android infobars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/MessageInfoBar.java ('k') | chrome/browser/ui/android/infobars/confirm_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

index 56cc46ef70c8d717f6e01fe13b42803eecd89638..cd2fcb5a98e48724125dbd0a3f9439b0e1d33b8a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

@@ -45,7 +45,7 @@ public class TranslateInfoBar extends InfoBar implements SubPanelListener {

int infoBarType, int sourceLanguageIndex, int targetLanguageIndex,

boolean autoTranslatePair, boolean shouldShowNeverBar,

boolean triggeredFromMenu, String[] languages) {

- super(null, R.drawable.infobar_translate, null);

+ super(null, R.drawable.infobar_translate, null, null);

mTranslateDelegate = delegate;

mOptions = new TranslateOptions(sourceLanguageIndex, targetLanguageIndex, languages,

autoTranslatePair, triggeredFromMenu);

@@ -181,9 +181,9 @@ public class TranslateInfoBar extends InfoBar implements SubPanelListener {

layout.setMessage(getMessageText(context));

layout.setButtons(getPrimaryButtonText(context), getSecondaryButtonText(context));

- if (getInfoBarType() == AFTER_TRANSLATE_INFOBAR &&

- !needsAlwaysPanel() &&

- !mOptions.triggeredFromMenu()) {

+ if (getInfoBarType() == AFTER_TRANSLATE_INFOBAR

+ && !needsAlwaysPanel()

+ && !mOptions.triggeredFromMenu()) {

// Long always translate version

TranslateCheckBox checkBox = new TranslateCheckBox(context, mOptions, this);

layout.setCustomContent(checkBox);