Source/core/html/forms/InputType.cpp - Issue 889563002: Make RenderObject::style() return a const object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/InputType.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated change after Doug's review. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/forms/InputType.cpp

diff --git a/Source/core/html/forms/InputType.cpp b/Source/core/html/forms/InputType.cpp

index 94209d5a4d3f86afd7a5ab0769d57a9c47833424..db27fffaf59e6b1ca7c06a19e9c3c8f967bc386d 100644

--- a/Source/core/html/forms/InputType.cpp

+++ b/Source/core/html/forms/InputType.cpp

@@ -592,7 +592,7 @@ String InputType::sanitizeValue(const String& proposedValue) const

void InputType::warnIfValueIsInvalidAndElementIsVisible(const String& value) const

{

// Don't warn if the value is set in Modernizr.

- LayoutStyle* style = element().layoutStyle();

+ const LayoutStyle* style = element().layoutStyle();

if (style && style->visibility() != HIDDEN)

warnIfValueIsInvalid(value);

}

@@ -892,7 +892,7 @@ void InputType::stepUpFromRenderer(int n)

void InputType::countUsageIfVisible(UseCounter::Feature feature) const

{

- if (LayoutStyle* style = element().layoutStyle()) {

+ if (const LayoutStyle* style = element().layoutStyle()) {

if (style->visibility() != HIDDEN)

UseCounter::count(element().document(), feature);

}