Source/core/html/HTMLOptionElement.cpp - Issue 889563002: Make RenderObject::style() return a const object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionElement.cpp

Issue 889563002: Make RenderObject::style() return a const object (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated change after Doug's review. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLOptionElement.cpp

diff --git a/Source/core/html/HTMLOptionElement.cpp b/Source/core/html/HTMLOptionElement.cpp

index 15a98821642b5d266b09a1b0be9b2c0142b13d51..6f4e4b8afe90d46917c34f41887c8db89cca1163 100644

--- a/Source/core/html/HTMLOptionElement.cpp

+++ b/Source/core/html/HTMLOptionElement.cpp

@@ -407,7 +407,7 @@ bool HTMLOptionElement::isDisplayNone() const

Element* parent = parentElement();

ASSERT(parent);

if (isHTMLOptGroupElement(*parent)) {

- LayoutStyle* parentStyle = parent->layoutStyle() ? parent->layoutStyle() : parent->computedStyle();

+ const LayoutStyle* parentStyle = parent->layoutStyle() ? parent->layoutStyle() : parent->computedStyle();

return !parentStyle || parentStyle->display() == NONE;

}