Issue 88943003: [rAC, OSX] Update 'enabled' status on edits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88943003: [rAC, OSX] Update 'enabled' status on edits. (Closed)

Created:
7 years ago by groby-ooo-7-16

Modified:
7 years ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[rAC, OSX] Update 'enabled' status on edits. When a field is modified, the dialog must update the 'editable' status for all fields in the section. BUG=321331 TEST=See bug. CVC should now be editable after editing expiration. R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238242

Patch Set 1 #

Patch Set 2 : Exclude invalid fields - prevents DCHECK from firing. #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -5 lines)			Patch
	M	chrome/browser/ui/cocoa/autofill/autofill_section_container.mm	View	1	6 chunks	+21 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/88943003/1

7 years ago (2013-11-26 21:37:11 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=193659

7 years ago (2013-11-26 23:53:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/88943003/20001

7 years ago (2013-12-02 19:41:19 UTC) #5

Message was sent while issue was closed.

Change committed as 238242

Expand Messages | Collapse Messages