[rAC, OSX] Update 'enabled' status on edits.

chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_section_container.h"
 
 #include <algorithm>
 
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 99 matching lines @@
 
 // Create a button offering input suggestions.
 - (MenuButton*)makeSuggestionButton;
 
 // Create a view with all inputs requested by |delegate_|. Autoreleased.
 - (LayoutView*)makeInputControls;
 
 // Refresh all field icons based on |delegate_| status.
 - (void)updateFieldIcons;
 
+// Refresh the enabled/disabled state of all input fields.
+- (void)updateEditability;
+
 @end
 
 @implementation AutofillSectionContainer
 
 @synthesize section = section_;
 @synthesize validationDelegate = validationDelegate_;
 
 - (id)initWithDelegate:(autofill::AutofillDialogViewDelegate*)delegate
             forSection:(autofill::DialogSection)section {
   if (self = [super init]) {
@@ skipping 145 matching lines @@
 }
 
 - (void)didChange:(id)sender {
   [self textfieldEditedOrActivated:sender edited:YES];
 }
 
 - (void)didEndEditing:(id)sender {
   delegate_->FocusMoved();
   [validationDelegate_ hideErrorBubble];
   [self validateFor:autofill::VALIDATE_EDIT];
+  [self updateEditability];
 }
 
 - (void)updateSuggestionState {
   const autofill::SuggestionState& suggestionState =
       delegate_->SuggestionStateForSection(section_);
   // TODO(estade): use |vertically_compact_text| when it fits.
   const base::string16& text = suggestionState.horizontally_compact_text;
   showSuggestions_ = suggestionState.visible;
 
   [suggestContainer_ setSuggestionText:base::SysUTF16ToNSString(text)
@@ skipping 77 matching lines @@
 
   return !messages.HasErrors();
 }
 
 - (NSString*)suggestionText {
   return showSuggestions_ ? [[suggestContainer_ inputField] stringValue] : nil;
 }
 
 - (void)addInputsToArray:(NSMutableArray*)array {
   [array addObjectsFromArray:[inputs_ subviews]];
-  [array addObject:[suggestContainer_ inputField]];
+
+  // Only credit card sections can have a suggestion input.
+  if ([self isCreditCardSection])
+    [array addObject:[suggestContainer_ inputField]];
 }
 
 #pragma mark Internal API for AutofillSectionContainer.
 
 - (void)textfieldEditedOrActivated:(NSControl<AutofillInputField>*)field
                             edited:(BOOL)edited {
   AutofillTextField* textfield =
       base::mac::ObjCCastStrict<AutofillTextField>(field);
 
   // This only applies to textfields.
@@ skipping 35 matching lines @@
 
     // If the field transitioned from invalid to valid, re-validate the group,
     // since inter-field checks become meaningful with valid fields.
     if (![textfield invalid])
       [self validateFor:autofill::VALIDATE_EDIT];
   }
 
   // Update the icon if necessary.
   if (delegate_->FieldControlsIcons(type))
     [self updateFieldIcons];
+  [self updateEditability];
 }
 
 - (autofill::ServerFieldType)fieldTypeForControl:(NSControl*)control {
   DCHECK([control tag]);
   return static_cast<autofill::ServerFieldType>([control tag]);
 }
 
 - (const autofill::DetailInput*)detailInputForType:
     (autofill::ServerFieldType)type {
   for (size_t i = 0; i < detailInputs_.size(); ++i) {
@@ skipping 34 matching lines @@
 - (void)updateAndClobber:(BOOL)shouldClobber {
   const autofill::DetailInputs& updatedInputs =
       delegate_->RequestedFieldsForSection(section_);
 
   for (autofill::DetailInputs::const_iterator iter = updatedInputs.begin();
        iter != updatedInputs.end();
        ++iter) {
     NSControl<AutofillInputField>* field = [inputs_ viewWithTag:iter->type];
     DCHECK(field);
 
-    // TODO(groby): We need to account for the fact editability state can change
-    // after any input in the same section is edited by the user.
-    [field setEnabled:delegate_->InputIsEditable(*iter, section_)];
-
     if (shouldClobber || [field isDefault]) {
       [field setFieldValue:base::SysUTF16ToNSString(iter->initial_value)];
     }
     if (shouldClobber)
       [field setValidityMessage:@""];
   }
+  [self updateEditability];
   [self updateFieldIcons];
   [self modelChanged];
 }
 
 - (BOOL)isCreditCardSection {
   return section_ == autofill::SECTION_CC ||
       section_ == autofill::SECTION_CC_BILLING;
 }
 
 - (MenuButton*)makeSuggestionButton {
@@ skipping 108 matching lines @@
 
   autofill::FieldIconMap fieldIcons = delegate_->IconsForFields(fieldValues);
   for (autofill::FieldIconMap::const_iterator iter = fieldIcons.begin();
        iter!= fieldIcons.end(); ++iter) {
     AutofillTextField* textfield = base::mac::ObjCCastStrict<AutofillTextField>(
         [inputs_ viewWithTag:iter->first]);
     [[textfield cell] setIcon:iter->second.ToNSImage()];
   }
 }
 
+- (void)updateEditability {
+
+  base::scoped_nsobject<NSMutableArray> controls([[NSMutableArray alloc] init]);
+  [self addInputsToArray:controls];
+  for (NSControl<AutofillInputField>* control in controls.get()) {
+    autofill::ServerFieldType type = [self fieldTypeForControl:control];
+    const autofill::DetailInput* input = [self detailInputForType:type];
+    [control setEnabled:delegate_->InputIsEditable(*input, section_)];
+  }
+}
+
 @end
 
 
 @implementation AutofillSectionContainer (ForTesting)
 
 - (NSControl*)getField:(autofill::ServerFieldType)type {
   return [inputs_ viewWithTag:type];
 }
 
 - (void)setFieldValue:(NSString*)text
@@ skipping 12 matching lines @@
 - (void)activateFieldForInput:(const autofill::DetailInput&)input {
   if ([self detailInputForType:input.type] != &input)
     return;
 
   NSControl<AutofillInputField>* field = [inputs_ viewWithTag:input.type];
   [[field window] makeFirstResponder:field];
   [self textfieldEditedOrActivated:field edited:NO];
 }
 
 @end