Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889283002: Remove Client= from device/serial/data_stream.mojom. (Closed)

Created:
5 years, 10 months ago by Sam McNally
Modified:
5 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Client= from device/serial/data_stream.mojom. BUG=451321 Committed: https://crrev.com/bc78a2320b50eba4fe397f1f838a82ad30b16cd6 Cr-Commit-Position: refs/heads/master@{#314231} Committed: https://crrev.com/e75ce35e220e849af5562b927c754bf6269223e1 Cr-Commit-Position: refs/heads/master@{#314773}

Patch Set 1 : #

Patch Set 2 : This time without racing message pipes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -513 lines) Patch
M device/serial/data_receiver.h View 2 chunks +2 lines, -0 lines 0 comments Download
M device/serial/data_receiver.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M device/serial/data_sender.h View 1 3 chunks +7 lines, -19 lines 0 comments Download
M device/serial/data_sender.cc View 1 9 chunks +44 lines, -128 lines 0 comments Download
M device/serial/data_sink_receiver.h View 1 5 chunks +15 lines, -19 lines 0 comments Download
M device/serial/data_sink_receiver.cc View 1 10 chunks +53 lines, -54 lines 0 comments Download
M device/serial/data_sink_unittest.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M device/serial/data_source_sender.h View 3 chunks +8 lines, -2 lines 0 comments Download
M device/serial/data_source_sender.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M device/serial/data_source_unittest.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M device/serial/data_stream.mojom View 1 2 chunks +9 lines, -18 lines 0 comments Download
M device/serial/data_stream_serialization.mojom View 1 2 chunks +2 lines, -3 lines 0 comments Download
M device/serial/serial.mojom View 1 1 chunk +2 lines, -1 line 0 comments Download
M device/serial/serial_connection.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M device/serial/serial_connection.cc View 1 1 chunk +11 lines, -13 lines 0 comments Download
M device/serial/serial_connection_factory.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M device/serial/serial_connection_factory.cc View 1 5 chunks +14 lines, -11 lines 0 comments Download
M device/serial/serial_connection_unittest.cc View 1 1 chunk +13 lines, -11 lines 0 comments Download
M device/serial/serial_service_impl.h View 1 1 chunk +7 lines, -5 lines 0 comments Download
M device/serial/serial_service_impl.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M device/serial/serial_service_unittest.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/renderer/api/serial/data_receiver_unittest.cc View 3 chunks +59 lines, -8 lines 0 comments Download
M extensions/renderer/api/serial/data_sender_unittest.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M extensions/renderer/resources/data_receiver.js View 8 chunks +24 lines, -17 lines 0 comments Download
M extensions/renderer/resources/data_sender.js View 1 15 chunks +37 lines, -150 lines 0 comments Download
M extensions/renderer/resources/serial_service.js View 1 4 chunks +11 lines, -5 lines 0 comments Download
M extensions/test/data/data_receiver_unittest.js View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Sam McNally
5 years, 10 months ago (2015-02-02 04:37:43 UTC) #3
Ken Rockot(use gerrit already)
lgtm
5 years, 10 months ago (2015-02-02 21:49:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889283002/20001
5 years, 10 months ago (2015-02-02 22:28:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-03 01:16:08 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bc78a2320b50eba4fe397f1f838a82ad30b16cd6 Cr-Commit-Position: refs/heads/master@{#314231}
5 years, 10 months ago (2015-02-03 01:17:22 UTC) #8
Sam McNally
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/873293006/ by sammc@chromium.org. ...
5 years, 10 months ago (2015-02-04 08:52:23 UTC) #9
Sam McNally
PTAL
5 years, 10 months ago (2015-02-05 03:31:05 UTC) #11
Ken Rockot(use gerrit already)
lgtm
5 years, 10 months ago (2015-02-05 05:14:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889283002/60001
5 years, 10 months ago (2015-02-05 06:42:02 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 10 months ago (2015-02-05 07:41:03 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 07:42:04 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e75ce35e220e849af5562b927c754bf6269223e1
Cr-Commit-Position: refs/heads/master@{#314773}

Powered by Google App Engine
This is Rietveld 408576698