Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: device/serial/serial_connection.cc

Issue 889283002: Remove Client= from device/serial/data_stream.mojom. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: This time without racing message pipes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/serial/serial_connection.h ('k') | device/serial/serial_connection_factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/serial/serial_connection.h" 5 #include "device/serial/serial_connection.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "device/serial/buffer.h" 8 #include "device/serial/buffer.h"
9 #include "device/serial/data_sink_receiver.h" 9 #include "device/serial/data_sink_receiver.h"
10 #include "device/serial/data_source_sender.h" 10 #include "device/serial/data_source_sender.h"
11 #include "device/serial/serial_io_handler.h" 11 #include "device/serial/serial_io_handler.h"
12 12
13 namespace device { 13 namespace device {
14 14
15 SerialConnection::SerialConnection( 15 SerialConnection::SerialConnection(
16 scoped_refptr<SerialIoHandler> io_handler, 16 scoped_refptr<SerialIoHandler> io_handler,
17 mojo::InterfaceRequest<serial::DataSink> sink, 17 mojo::InterfaceRequest<serial::DataSink> sink,
18 mojo::InterfaceRequest<serial::DataSource> source) 18 mojo::InterfaceRequest<serial::DataSource> source,
19 mojo::InterfacePtr<serial::DataSourceClient> source_client)
19 : io_handler_(io_handler) { 20 : io_handler_(io_handler) {
20 receiver_ = mojo::WeakBindToRequest( 21 receiver_ = new DataSinkReceiver(
21 new DataSinkReceiver(base::Bind(&SerialConnection::OnSendPipeReady, 22 sink.Pass(),
22 base::Unretained(this)), 23 base::Bind(&SerialConnection::OnSendPipeReady, base::Unretained(this)),
23 base::Bind(&SerialConnection::OnSendCancelled, 24 base::Bind(&SerialConnection::OnSendCancelled, base::Unretained(this)),
24 base::Unretained(this)), 25 base::Bind(base::DoNothing));
25 base::Bind(base::DoNothing)), 26 sender_ = new DataSourceSender(
26 &sink); 27 source.Pass(), source_client.Pass(),
27 sender_ = mojo::WeakBindToRequest( 28 base::Bind(&SerialConnection::OnReceivePipeReady, base::Unretained(this)),
28 new DataSourceSender(base::Bind(&SerialConnection::OnReceivePipeReady, 29 base::Bind(base::DoNothing));
29 base::Unretained(this)),
30 base::Bind(base::DoNothing)),
31 &source);
32 } 30 }
33 31
34 SerialConnection::~SerialConnection() { 32 SerialConnection::~SerialConnection() {
35 receiver_->ShutDown(); 33 receiver_->ShutDown();
36 sender_->ShutDown(); 34 sender_->ShutDown();
37 io_handler_->CancelRead(serial::RECEIVE_ERROR_DISCONNECTED); 35 io_handler_->CancelRead(serial::RECEIVE_ERROR_DISCONNECTED);
38 io_handler_->CancelWrite(serial::SEND_ERROR_DISCONNECTED); 36 io_handler_->CancelWrite(serial::SEND_ERROR_DISCONNECTED);
39 } 37 }
40 38
41 void SerialConnection::GetInfo( 39 void SerialConnection::GetInfo(
(...skipping 28 matching lines...) Expand all
70 68
71 void SerialConnection::OnSendPipeReady(scoped_ptr<ReadOnlyBuffer> buffer) { 69 void SerialConnection::OnSendPipeReady(scoped_ptr<ReadOnlyBuffer> buffer) {
72 io_handler_->Write(buffer.Pass()); 70 io_handler_->Write(buffer.Pass());
73 } 71 }
74 72
75 void SerialConnection::OnReceivePipeReady(scoped_ptr<WritableBuffer> buffer) { 73 void SerialConnection::OnReceivePipeReady(scoped_ptr<WritableBuffer> buffer) {
76 io_handler_->Read(buffer.Pass()); 74 io_handler_->Read(buffer.Pass());
77 } 75 }
78 76
79 } // namespace device 77 } // namespace device
OLDNEW
« no previous file with comments | « device/serial/serial_connection.h ('k') | device/serial/serial_connection_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698