Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 889153004: [Cleanup] Clean up Easy Unlock code a bit. (Closed)

Created:
5 years, 10 months ago by Ilya Sherman
Modified:
5 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Clean up Easy Unlock code a bit. Add an IsEnabled() method to the EasyUnlockService, and other minor cleanup. BUG=none TEST=none R=xiyuan@chromium.org Committed: https://crrev.com/8787ad84e79b909f951bdca491ab1ef48a7ead3c Cr-Commit-Position: refs/heads/master@{#314758}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and remove TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
M chrome/browser/resources/options/browser_options.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ilya Sherman
https://chromiumcodereview.appspot.com/889153004/diff/1/chrome/browser/ui/webui/options/browser_options_handler.cc File chrome/browser/ui/webui/options/browser_options_handler.cc (right): https://chromiumcodereview.appspot.com/889153004/diff/1/chrome/browser/ui/webui/options/browser_options_handler.cc#newcode2039 chrome/browser/ui/webui/options/browser_options_handler.cc:2039: // TODO(xiyuan): Update when pairing data is really availble. ...
5 years, 10 months ago (2015-02-05 02:27:50 UTC) #1
xiyuan
lgtm https://chromiumcodereview.appspot.com/889153004/diff/1/chrome/browser/ui/webui/options/browser_options_handler.cc File chrome/browser/ui/webui/options/browser_options_handler.cc (right): https://chromiumcodereview.appspot.com/889153004/diff/1/chrome/browser/ui/webui/options/browser_options_handler.cc#newcode2039 chrome/browser/ui/webui/options/browser_options_handler.cc:2039: // TODO(xiyuan): Update when pairing data is really ...
5 years, 10 months ago (2015-02-05 03:30:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889153004/20001
5 years, 10 months ago (2015-02-05 03:35:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 04:50:50 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 04:51:35 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8787ad84e79b909f951bdca491ab1ef48a7ead3c
Cr-Commit-Position: refs/heads/master@{#314758}

Powered by Google App Engine
This is Rietveld 408576698