chrome/browser/signin/easy_unlock_service_signin_chromeos.cc - Issue 889153004: [Cleanup] Clean up Easy Unlock code a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/easy_unlock_service_signin_chromeos.cc

Issue 889153004: [Cleanup] Clean up Easy Unlock code a bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and remove TODOs Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/signin/easy_unlock_service_signin_chromeos.cc

diff --git a/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc b/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc

index 5a16da91c8a6cd3a6e62f4ad7be04cef92f845c3..7f8fda558d3e455c5cc5999e501ddfe7608cd7e3 100644

--- a/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc

+++ b/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc

@@ -284,7 +284,7 @@ void EasyUnlockServiceSignin::ShutdownInternal() {

user_data_.clear();

}

-bool EasyUnlockServiceSignin::IsAllowedInternal() {

+bool EasyUnlockServiceSignin::IsAllowedInternal() const {

return service_active_ &&

!user_id_.empty() &&

!chromeos::LoginState::Get()->IsUserLoggedIn();