Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 888963002: Revert of Add build targets for Opus tests. (Closed)

Created:
5 years, 10 months ago by please use gerrit instead
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add build targets for Opus tests. (patchset #5 id:80001 of https://codereview.chromium.org/890473002/) Reason for revert: Broke Mac GN (dbg) bot. [169/1394] STAMP obj/third_party/cacheinvalidation/cacheinvalidation_unittests.inputdeps.stamp FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF obj/third_party/opus/src/tests/test_opus_decode.test_opus_decode.o.d -DCHROMIUM_BUILD -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_OPENSSL=1 -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DENABLE_REMOTING=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DCR_CLANG_REVISION=223108 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen -I../../third_party/opus/src/celt -I../../third_party/opus/src/silk -I../../third_party/opus/src/include -fno-strict-aliasing -fstack-protector-all -arch x86_64 -fcolor-diagnostics -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wnewline-eof -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal -Wno-inconsistent-missing-override -fvisibility=hidden -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O0 -g2 -Wno-absolute-value -std=c99 -c ../../third_party/opus/src/tests/test_opus_decode.c -o obj/third_party/opus/src/tests/test_opus_decode.test_opus_decode.o ../../third_party/opus/src/tests/test_opus_decode.c:138:64: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull] out_samples = opus_decode(dec[t], packet, 0, 0, 0, fec); ~ ^ 1 error generated. ninja: build stopped: subcommand failed. http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/3538 Original issue's description: > Add build targets for Opus tests. > > test_opus_api, test_opus_encode, test_opus_decode, and test_opus_padding > can be run directly, with no command-line options, and they print out > "OK" during the test and an overall status message such as > "All API tests passed." or "Tests completed successfully." at the end. > > The celt component has several unit tests. I didn't add build targets > for them because some of them don't print any output, so you'd need a > test harness script to examine their exit status. > > R=henrika@chromium.org,sergeyu@chromium.org > BUG=452984 > > Committed: https://crrev.com/bfcc6156a8f2107ecd70445b08e60299737caffa > Cr-Commit-Position: refs/heads/master@{#313964} TBR=henrika@chromium.org,sergeyu@chromium.org,brettw@chromium.org,wtc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452984 Committed: https://crrev.com/f6cba75468a9a3096ee50195faa2bff6ec4bcadc Cr-Commit-Position: refs/heads/master@{#313965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -157 lines) Patch
M third_party/opus/BUILD.gn View 4 chunks +32 lines, -90 lines 0 comments Download
M third_party/opus/opus.gyp View 3 chunks +42 lines, -67 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
please use gerrit instead
Created Revert of Add build targets for Opus tests.
5 years, 10 months ago (2015-01-30 19:57:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888963002/1
5 years, 10 months ago (2015-01-30 19:58:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 20:00:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f6cba75468a9a3096ee50195faa2bff6ec4bcadc Cr-Commit-Position: refs/heads/master@{#313965}
5 years, 10 months ago (2015-01-30 20:01:31 UTC) #4
wtc
5 years, 10 months ago (2015-02-03 03:20:51 UTC) #5
Message was sent while issue was closed.
LGTM. Thank you for covering for me.

Powered by Google App Engine
This is Rietveld 408576698