Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/opus/opus.gyp

Issue 888963002: Revert of Add build targets for Opus tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/opus/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/opus/opus.gyp
diff --git a/third_party/opus/opus.gyp b/third_party/opus/opus.gyp
index 437344c8d4131e1394fdfefe7c7d1e25dc64582b..5fdeea6e230ea7176fcf06f392a8bf27107c2d58 100644
--- a/third_party/opus/opus.gyp
+++ b/third_party/opus/opus.gyp
@@ -28,33 +28,6 @@
'use_opus_rtcd%': 1,
}, {
'use_opus_rtcd%': 0,
- }],
- ],
- },
- 'target_defaults': {
- 'target_conditions': [
- ['_type=="executable"', {
- # All of the executable targets depend on 'opus'. Unfortunately the
- # 'dependencies' block cannot be inherited via 'target_defaults'.
- 'include_dirs': [
- 'src/celt',
- 'src/silk',
- ],
- 'conditions': [
- ['OS == "win"', {
- 'defines': [
- 'inline=__inline',
- ],
- }],
- ['OS=="android"', {
- 'libraries': [
- '-llog',
- ],
- }],
- ['clang==1', {
- 'cflags': [ '-Wno-absolute-value' ],
- }]
- ],
}],
],
},
@@ -178,8 +151,29 @@
'dependencies': [
'opus'
],
+ 'conditions': [
+ ['OS == "win"', {
+ 'defines': [
+ 'inline=__inline',
+ ],
+ }],
+ ['OS=="android"', {
+ 'link_settings': {
+ 'libraries': [
+ '-llog',
+ ],
+ },
+ }],
+ ['clang==1', {
+ 'cflags': [ '-Wno-absolute-value' ],
+ }]
+ ],
'sources': [
'src/src/opus_compare.c',
+ ],
+ 'include_dirs': [
+ 'src/celt',
+ 'src/silk',
],
}, # target opus_compare
{
@@ -188,49 +182,30 @@
'dependencies': [
'opus'
],
+ 'conditions': [
+ ['OS == "win"', {
+ 'defines': [
+ 'inline=__inline',
+ ],
+ }],
+ ['OS=="android"', {
+ 'link_settings': {
+ 'libraries': [
+ '-llog',
+ ],
+ },
+ }],
+ ['clang==1', {
+ 'cflags': [ '-Wno-absolute-value' ],
+ }]
+ ],
'sources': [
'src/src/opus_demo.c',
],
+ 'include_dirs': [
+ 'src/celt',
+ 'src/silk',
+ ],
}, # target opus_demo
- {
- 'target_name': 'test_opus_api',
- 'type': 'executable',
- 'dependencies': [
- 'opus'
- ],
- 'sources': [
- 'src/tests/test_opus_api.c',
- ],
- }, # target test_opus_api
- {
- 'target_name': 'test_opus_encode',
- 'type': 'executable',
- 'dependencies': [
- 'opus'
- ],
- 'sources': [
- 'src/tests/test_opus_encode.c',
- ],
- }, # target test_opus_encode
- {
- 'target_name': 'test_opus_decode',
- 'type': 'executable',
- 'dependencies': [
- 'opus'
- ],
- 'sources': [
- 'src/tests/test_opus_decode.c',
- ],
- }, # target test_opus_decode
- {
- 'target_name': 'test_opus_padding',
- 'type': 'executable',
- 'dependencies': [
- 'opus'
- ],
- 'sources': [
- 'src/tests/test_opus_padding.c',
- ],
- }, # target test_opus_padding
]
}
« no previous file with comments | « third_party/opus/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698