DescriptionRevert of Revert "compositor: Fix texture flipping for SW mirroring with surfaceless" (patchset #1 id:20001 of https://codereview.chromium.org/865673003/)
Reason for revert:
This isn't the cause of the crash
Original issue's description:
> This reverts two CLs
> "compositor: Fix texture flipping for SW mirroring with surfaceless"
> and
> "Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds."
>
> Reason for revert:
> The original patch breaks software mirroring mode on at least veyron_jerry,
> and quite possibly all non-freon systems.
>
> >Original issue's descriptions:
> > Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds.
> > This fixes the GN build on Android after https://codereview.chromium.org/846063002.
> >
> > (The GYP build didn't break because content/browser/compositor/ is completely excluded there; see https://code.google.com/p/chromium/codesearch#chromium/src/content/content_tests.gypi&sq=package:chromium&&type=cs&l=1099)
> >
> > TBR=bauerb@chromium.org
> >
> > Review URL: https://codereview.chromium.org/879543002
> >
> > Cr-Commit-Position: refs/heads/master@{#313074}
>
> > compositor: Fix texture flipping for SW mirroring with surfaceless
> >
> > Ozone-surfaceless renders the scene flipped, so the texture contents are
> > inverted from what they should be. This fixes the mirroring logic to
> > un-flip the texture when needed, and also to send the right sub-buffer
> > update rect.
> >
> > BUG=434115
> >
> > Committed: https://crrev.com/c6a481fe79e0c4851a576495105edf2600bfe5be
> > Cr-Commit-Position: refs/heads/master@{#312979}
>
> TBR=danakj@chromium.org,achaulk@chromium.org,bauerb@chromium.org
> BUG=434115, 451804
>
> Committed: https://crrev.com/6302d690c0b3aa762b92300564d9313876c6a2bf
> Cr-Commit-Position: refs/heads/master@{#313610}
TBR=danakj@chromium.org,bauerb@chromium.org,oshima@chromium.org
BUG=434115, 451804
Committed: https://crrev.com/01137b8010c18ee19783e8a8754b0bb1ede645e6
Cr-Commit-Position: refs/heads/master@{#313847}
Patch Set 1 #
Created: 5 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 8 (1 generated)
|