Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 888653002: Revert of Revert "compositor: Fix texture flipping for SW mirroring with surfaceless" (Closed)

Created:
5 years, 10 months ago by achaulk
Modified:
5 years, 10 months ago
CC:
chromium-reviews, sadrul, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org, Daniel Kurtz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "compositor: Fix texture flipping for SW mirroring with surfaceless" (patchset #1 id:20001 of https://codereview.chromium.org/865673003/) Reason for revert: This isn't the cause of the crash Original issue's description: > This reverts two CLs > "compositor: Fix texture flipping for SW mirroring with surfaceless" > and > "Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds." > > Reason for revert: > The original patch breaks software mirroring mode on at least veyron_jerry, > and quite possibly all non-freon systems. > > >Original issue's descriptions: > > Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds. > > This fixes the GN build on Android after https://codereview.chromium.org/846063002. > > > > (The GYP build didn't break because content/browser/compositor/ is completely excluded there; see https://code.google.com/p/chromium/codesearch#chromium/src/content/content_tests.gypi&sq=package:chromium&&type=cs&l=1099) > > > > TBR=bauerb@chromium.org > > > > Review URL: https://codereview.chromium.org/879543002 > > > > Cr-Commit-Position: refs/heads/master@{#313074} > > > compositor: Fix texture flipping for SW mirroring with surfaceless > > > > Ozone-surfaceless renders the scene flipped, so the texture contents are > > inverted from what they should be. This fixes the mirroring logic to > > un-flip the texture when needed, and also to send the right sub-buffer > > update rect. > > > > BUG=434115 > > > > Committed: https://crrev.com/c6a481fe79e0c4851a576495105edf2600bfe5be > > Cr-Commit-Position: refs/heads/master@{#312979} > > TBR=danakj@chromium.org,achaulk@chromium.org,bauerb@chromium.org > BUG=434115, 451804 > > Committed: https://crrev.com/6302d690c0b3aa762b92300564d9313876c6a2bf > Cr-Commit-Position: refs/heads/master@{#313610} TBR=danakj@chromium.org,bauerb@chromium.org,oshima@chromium.org BUG=434115, 451804 Committed: https://crrev.com/01137b8010c18ee19783e8a8754b0bb1ede645e6 Cr-Commit-Position: refs/heads/master@{#313847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -19 lines) Patch
M cc/layers/texture_layer.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/reflector_impl.h View 5 chunks +10 lines, -4 lines 0 comments Download
M content/browser/compositor/reflector_impl.cc View 4 chunks +16 lines, -9 lines 0 comments Download
A content/browser/compositor/reflector_impl_unittest.cc View 1 chunk +155 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/layer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/layer.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/compositor/reflector.h View 1 chunk +6 lines, -4 lines 0 comments Download
A ui/compositor/reflector.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
achaulk
Created Revert of Revert "compositor: Fix texture flipping for SW mirroring with surfaceless"
5 years, 10 months ago (2015-01-29 17:29:51 UTC) #1
achaulk
not a committer so i need an lgtm. Verified this isn't the cause of the ...
5 years, 10 months ago (2015-01-29 17:30:48 UTC) #2
oshima
On 2015/01/29 17:30:48, achaulk wrote: > not a committer so i need an lgtm. > ...
5 years, 10 months ago (2015-01-29 19:27:42 UTC) #3
oshima
lgtm
5 years, 10 months ago (2015-01-29 23:06:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888653002/1
5 years, 10 months ago (2015-01-29 23:07:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 01:03:33 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 01:06:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01137b8010c18ee19783e8a8754b0bb1ede645e6
Cr-Commit-Position: refs/heads/master@{#313847}

Powered by Google App Engine
This is Rietveld 408576698