Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 879543002: Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds. (Closed)

Created:
5 years, 11 months ago by Bernhard Bauer
Modified:
5 years, 11 months ago
Reviewers:
whywhat, achaulk
CC:
chromium-reviews, darin-cc_chromium.org, jam, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds. This fixes the GN build on Android after https://codereview.chromium.org/846063002. (The GYP build didn't break because content/browser/compositor/ is completely excluded there; see https://code.google.com/p/chromium/codesearch#chromium/src/content/content_tests.gypi&sq=package:chromium&&type=cs&l=1099) TBR=bauerb@chromium.org Committed: https://crrev.com/09fa2e56bc152947276c8b535e9216a59fc5cdfc Cr-Commit-Position: refs/heads/master@{#313074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Bernhard Bauer
Please review.
5 years, 11 months ago (2015-01-26 14:56:11 UTC) #4
achaulk
lgtm
5 years, 11 months ago (2015-01-26 15:00:06 UTC) #5
whywhat
lgtm
5 years, 11 months ago (2015-01-26 15:07:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/879543002/1
5 years, 11 months ago (2015-01-26 15:10:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 15:59:39 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 16:00:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09fa2e56bc152947276c8b535e9216a59fc5cdfc
Cr-Commit-Position: refs/heads/master@{#313074}

Powered by Google App Engine
This is Rietveld 408576698