src/isolate.cc - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index ea5e3a95c93eb46aaaccbdf9b74c1c9dc89dfa15..3479ae239263d596ddc3ec764efcc40ce1569cdc 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -1560,7 +1560,7 @@ Isolate::ThreadDataTable::~ThreadDataTable() {

// TODO(svenpanne) The assertion below would fire if an embedder does not

// cleanly dispose all Isolates before disposing v8, so we are conservative

// and leave it out for now.

- // DCHECK_EQ(NULL, list_);

+ // DCHECK_NULL(list_);

}

« no previous file with comments | « src/ic/x64/stub-cache-x64.cc ('k') | src/jsregexp.h » ('j') | no next file with comments »