src/jsregexp.h - Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/jsregexp.h

Issue 888613002: Initial switch to Chromium-style CHECK_* and DCHECK_* macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CHECK_NULL/NOT_NULL is back. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/jsregexp.h

diff --git a/src/jsregexp.h b/src/jsregexp.h

index d74b3bcbbe3b1e5a51d6fbd8e413ffbd5b6b02f9..0b4f39dc494db4ae25a7e2391f529afb785f2db8 100644

--- a/src/jsregexp.h

+++ b/src/jsregexp.h

@@ -239,7 +239,7 @@ class CharacterRange {

public:

CharacterRange() : from_(0), to_(0) { }

// For compatibility with the CHECK_OK macro

- CharacterRange(void* null) { DCHECK_EQ(NULL, null); } //NOLINT

+ CharacterRange(void* null) { DCHECK_NULL(null); } // NOLINT

CharacterRange(uc16 from, uc16 to) : from_(from), to_(to) { }

static void AddClassEscape(uc16 type, ZoneList<CharacterRange>* ranges,

Zone* zone);

« no previous file with comments | « src/isolate.cc ('k') | src/jsregexp.cc » ('j') | no next file with comments »