extensions/browser/guest_view/web_view/web_view_constants.h - Issue 888563003: <webview>: Navigate to about:blank if attempting to navigate to bad URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_constants.h

Issue 888563003: <webview>: Navigate to about:blank if attempting to navigate to bad URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed lazyboy's comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/shim/main.js ('k') | extensions/browser/guest_view/web_view/web_view_constants.cc » ('j') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_constants.h

diff --git a/extensions/browser/guest_view/web_view/web_view_constants.h b/extensions/browser/guest_view/web_view/web_view_constants.h

index 5d102764bd88541cbbdc82720a1f796b74a993db..936000f83295347c7de8bf0dc9ff158577dd9ee6 100644

--- a/extensions/browser/guest_view/web_view/web_view_constants.h

+++ b/extensions/browser/guest_view/web_view/web_view_constants.h

@@ -110,6 +110,7 @@ extern const char kFindDone[];

extern const char kParameterUserAgentOverride[];

// Miscellaneous.

+extern const char kAboutBlankURL[];

Charlie Reis 2015/02/03 18:14:57 As lazyboy@ mentioned, just use the existing url::

extern const char kMenuItemCommandId[];

extern const char kMenuItemLabel[];

extern const char kPersistPrefix[];