extensions/browser/guest_view/web_view/web_view_constants.h - Issue 888563003: <webview>: Navigate to about:blank if attempting to navigate to bad URL

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/guest_view/web_view/web_view_constants.h

Issue 888563003: <webview>: Navigate to about:blank if attempting to navigate to bad URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed lazyboy's comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/shim/main.js ('k') | extensions/browser/guest_view/web_view/web_view_constants.cc » ('j') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Constants used for the WebView API.	5 // Constants used for the WebView API.

6	6

7 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_CONSTANTS_H_	7 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_CONSTANTS_H_

8 #define EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_CONSTANTS_H_	8 #define EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_CONSTANTS_H_

9	9

10 namespace webview {	10 namespace webview {

(...skipping 92 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
103 extern const char kFindRectTop[];	103 extern const char kFindRectTop[];

104 extern const char kFindRectWidth[];	104 extern const char kFindRectWidth[];

105 extern const char kFindRectHeight[];	105 extern const char kFindRectHeight[];

106 extern const char kFindCanceled[];	106 extern const char kFindCanceled[];

107 extern const char kFindDone[];	107 extern const char kFindDone[];

108	108

109 // Initialization parameters.	109 // Initialization parameters.

110 extern const char kParameterUserAgentOverride[];	110 extern const char kParameterUserAgentOverride[];

111	111

112 // Miscellaneous.	112 // Miscellaneous.

	113 extern const char kAboutBlankURL[];
	Charlie Reis 2015/02/03 18:14:57 As lazyboy@ mentioned, just use the existing url:: As lazyboy@ mentioned, just use the existing url::kAboutBlankURL rather than introducing a new one.
113 extern const char kMenuItemCommandId[];	114 extern const char kMenuItemCommandId[];

114 extern const char kMenuItemLabel[];	115 extern const char kMenuItemLabel[];

115 extern const char kPersistPrefix[];	116 extern const char kPersistPrefix[];

116 extern const char kStoragePartitionId[];	117 extern const char kStoragePartitionId[];

117 extern const unsigned int kMaxOutstandingPermissionRequests;	118 extern const unsigned int kMaxOutstandingPermissionRequests;

118 extern const int kInvalidPermissionRequestID;	119 extern const int kInvalidPermissionRequestID;

119	120

120 } // namespace webview	121 } // namespace webview

121	122

122 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_CONSTANTS_H_	123 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_CONSTANTS_H_

OLD	NEW