<webview>: Navigate to about:blank if attempting to navigate to bad URL

<webview>: Navigate to about:blank if attempting to navigate to bad URL

If <webview> attempts to navigate to a URL that is invalid or it cannot
access, it will fire a loadabort message. However, a loadstop will not fire
and <webview> may remain in an unnavigated state despite having a set src
attribute. This causes various APIs such as executeScript to fail.

This CL navigates <webview> to about:blank in the case of a bad navigation.
This puts <webview> back to a sane state.

BUG=450125
Committed: https://crrev.com/fb12824b8b2caf76dbb341ef53f3225d09f0ca86
Cr-Commit-Position: refs/heads/master@{#314517}

[Fady Samuel, 2015-02-03 08:34:36]

fsamuel@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2015-02-03 09:07:46]

It is unclear to me how this fixes crbug.com/450125, can you explain? Also
possibly add those comments/explanation to WebViewGuest::NavigateGuest() and
update the CL description.

https://codereview.chromium.org/888563003/diff/20001/extensions/browser/guest...
File extensions/browser/guest_view/web_view/web_view_guest.cc (right):

https://codereview.chromium.org/888563003/diff/20001/extensions/browser/guest...
extensions/browser/guest_view/web_view/web_view_guest.cc:882:
NavigateGuest("about:blank", true /* force_navigation */);
s/"about:blank"/kAboutBlankURL

[Fady Samuel, 2015-02-03 09:34:23]

fsamuel@chromium.org changed reviewers:
+ creis@chromium.org

[Fady Samuel, 2015-02-03 10:27:26]

PTAL

[lazyboy, 2015-02-03 17:36:40]

lgtm

https://chromiumcodereview.appspot.com/888563003/diff/40001/extensions/browse...
File extensions/browser/guest_view/web_view/web_view_guest.cc (right):

https://chromiumcodereview.appspot.com/888563003/diff/40001/extensions/browse...
extensions/browser/guest_view/web_view/web_view_guest.cc:882:
NavigateGuest(webview::kAboutBlankURL, true /* force_navigation */);
Sorry for being vague here, I meant to use kAboutBlankURL from url_constants.h

https://chromiumcodereview.appspot.com/888563003/diff/40001/extensions/browse...
extensions/browser/guest_view/web_view/web_view_guest.cc:882:
NavigateGuest(webview::kAboutBlankURL, true /* force_navigation */);
Also add a comment here.

[Charlie Reis, 2015-02-03 18:14:57]

I agree that this is an improvement over the current <webview> blocked URL
behavior, so LGTM once lazyboy's comments are fixed.

However, I think this is more about improving the general window.open case in
<webview> (blocking chrome:// navigations) than Language Settings.  Mentioning
Language Settings in the CL description is confusing to me, because that's a
feature that *should* work.  (A guest should not be able to window.open to the
"chrome://settings/languages" URL, but if there is a context menu item for
Language Settings, it should work.)

https://codereview.chromium.org/888563003/diff/40001/extensions/browser/guest...
File extensions/browser/guest_view/web_view/web_view_constants.h (right):

https://codereview.chromium.org/888563003/diff/40001/extensions/browser/guest...
extensions/browser/guest_view/web_view/web_view_constants.h:113: extern const
char kAboutBlankURL[];
As lazyboy@ mentioned, just use the existing url::kAboutBlankURL rather than
introducing a new one.

[Charlie Reis, 2015-02-03 18:16:31]

(In other words, Language Settings should *not* fire a newwindow event.  It's a
browser-initiated event that should go directly to the embedder WebContents's
OpenURL.)

[Fady Samuel, 2015-02-04 06:32:03]

On 2015/02/03 18:16:31, Charlie Reis wrote:
> (In other words, Language Settings should *not* fire a newwindow event.  It's
a
> browser-initiated event that should go directly to the embedder WebContents's
> OpenURL.)

I see I'll update the other patch. Thnanks!

[Fady Samuel, 2015-02-04 06:32:29]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-02-04 06:33:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/888563003/60001

[commit-bot: I haz the power, 2015-02-04 07:28:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-04 07:29:44]

Patchset 4 (id:??) landed as
https://crrev.com/fb12824b8b2caf76dbb341ef53f3225d09f0ca86
Cr-Commit-Position: refs/heads/master@{#314517}