Issue 888483002: Remove 'f' from 0.05f in shader code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 888483002: Remove 'f' from 0.05f in shader code (Closed)

Created:
5 years, 10 months ago by robertphillips

Modified:
5 years, 10 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Remove 'f' from 0.05f in shader code TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/1726997861fac8daa8213d1a51d5c8fbe44428d1

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/gpu/effects/GrConvexPolyEffect.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/888483002/1

5 years, 10 months ago (2015-01-28 23:07:50 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/1726997861fac8daa8213d1a51d5c8fbe44428d1

5 years, 10 months ago (2015-01-28 23:19:57 UTC) #4

robertphillips

5 years, 10 months ago (2015-01-29 01:32:33 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/890433002/ by robertphillips@google.com.

The reason for reverting is: Chrome pixel test.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages