Finished swap out of old API

Finished swap out of old API

Replaced occurrences of [HyperlinkTextView setMessageAndLink:withLink:
atOffset:font:messageColor:linkColor:] with
[HyperLinkTextView setMessage:withFont:messageColor] and
[HyperLinkTextView addLinkRange:withName:linkColor:]. Removed the
[HyperLinkTextView setMessageAndLink:withLink:...] method.

BUG=253755
TEST=it's very difficult to produce test sequences for most of these changes.
Here is the one sequence I do have:

for sad_tab_view_cocoa.mm: Launch Chrome, run
    ps augx | grep “Chrome Helper”
in a Terminal window, create a new tab and go to some page, run the ps...
commands again and figure out the process number of the new Chrome
Helper (the one that wasn’t there before). In a Terminal window type kill -9
<XXX> where <XXX> is the process id of the new Chrome Helper. Confirm
the new tab now shows the sad tab page and that the last line of text reads,
“If you're seeing this frequently, try these suggestions.” with the word
“suggestions” as a clickable link that takes you to the “Aw, Snap!” Chrome
help page.

Committed: https://crrev.com/f14f8f0ee94f50e6c0387c6574f827d294fca301
Cr-Commit-Position: refs/heads/master@{#315054}

[shrike, 2015-01-30 22:01:11]

shrike@chromium.org changed reviewers:
+ groby@chromium.org

[shrike, 2015-01-30 22:09:14]

Here is the remainder of the API swap out changes. You are listed as an owner
for all of this code except (I think) for the hierarchy that contains
HyperLinkTextView - should I add another person to the reviewer's list?

Best,

__jayson

[groby-ooo-7-16, 2015-01-30 23:08:39]

groby@chromium.org changed reviewers:
+ thakis@chromium.org

[groby-ooo-7-16, 2015-01-30 23:08:40]

Yes, you'll need to add OWNERs that cover all files - I've added thakis@ here,
since IIRC I discussed this change with him way back when the new API got added.

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm
(right):

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm:32:
NSMutableString* finalMessage =
I'd suggest doing the string composition in C++ instead of objc, it's a bit more
succinct, skipping the intermediate NSMutableString. I.e:

base::string16 message = delegate->GetTextMessageWithOffset(&offset);
base::string16 linkText = delegate->GetLinkText(); 
message.insert(offset, linkText);
....
[view setMessage:base::SysUTF16ToNSString(message)
             withFont:font
     messageColor:[NSColor blackColor]];
[view addLinkRange: NSMakeRange(offset, linkText.size()]

(I prefer to postpone type conversion until it is absolutely necessary, as well)

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm (right):

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm:119: [NSFont
systemFontSizeForControlSize:NSRegularControlSize]];
I suppose this is "git cl format"'s doing?

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.mm (right):

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:259: [learnMoreText
length])
nit: parameters should be aligned

[groby-ooo-7-16, 2015-01-30 23:11:01]

Oh, and FWIW, you can crash the renderer by navigating to chrome://crash - much
easier :)

And one more nit: you do want to line-break commit messages around 72 chars, if
possible. Makes reading the logs on the command line much easier

[shrike, 2015-02-02 17:39:13]

groby, hanks for tips about crashing the renderer and 72 char line length.
PTAL.

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm
(right):

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm:32:
NSMutableString* finalMessage =
On 2015/01/30 23:08:39, groby wrote:
> I'd suggest doing the string composition in C++ instead of objc, it's a bit
more
> succinct, skipping the intermediate NSMutableString. I.e:

I agree. Done.

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm (right):

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm:119: [NSFont
systemFontSizeForControlSize:NSRegularControlSize]];
On 2015/01/30 23:08:39, groby wrote:
> I suppose this is "git cl format"'s doing?

No - me learning the style guide. Done.

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.mm (right):

https://codereview.chromium.org/887823002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:259: [learnMoreText
length])
On 2015/01/30 23:08:39, groby wrote:
> nit: parameters should be aligned 

The style guide had me confused on continuation lines. Done.

[groby-ooo-7-16, 2015-02-05 22:41:29]

c/b/ui/cocoa LGTM (and sorry for the lateness. If you don't get a reply to a CL
within 24 hours, it's more than OK to ping people).

thakis@: Ping for ui/base/cocoa :)

[Nico, 2015-02-05 22:46:33]

ui/base/cocoa lgtm (i usually wait for the main review to be done)

[shrike, 2015-02-06 17:23:13]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2015-02-06 17:24:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/887823002/40001

[commit-bot: I haz the power, 2015-02-06 17:27:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-06 17:28:24]

Patchset 3 (id:??) landed as
https://crrev.com/f14f8f0ee94f50e6c0387c6574f827d294fca301
Cr-Commit-Position: refs/heads/master@{#315054}