ui/base/cocoa/controls/hyperlink_text_view.mm - Issue 887823002: Finished swap out of old API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/cocoa/controls/hyperlink_text_view.mm

Issue 887823002: Finished swap out of old API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed formatting issues, changed code to perform string operations in C++ rather than ObjC Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/cocoa/controls/hyperlink_text_view.mm

diff --git a/ui/base/cocoa/controls/hyperlink_text_view.mm b/ui/base/cocoa/controls/hyperlink_text_view.mm

index 0afaafa11f9755255824740602cce5e5fe4ffc39..092c096e9934d6a0fb2676de28460c4a2e6dacea 100644

--- a/ui/base/cocoa/controls/hyperlink_text_view.mm

+++ b/ui/base/cocoa/controls/hyperlink_text_view.mm

@@ -101,22 +101,6 @@ const float kTextBaselineShift = -1.0;

[[NSCursor arrowCursor] set];

}

-- (void)setMessageAndLink:(NSString*)message

- withLink:(NSString*)link

- atOffset:(NSUInteger)linkOffset

- font:(NSFont*)font

- messageColor:(NSColor*)messageColor

- linkColor:(NSColor*)linkColor {

- NSMutableString* finalMessage = [NSMutableString stringWithString:message];

- [finalMessage insertString:link atIndex:linkOffset];

- [self setMessage:finalMessage withFont:font messageColor:messageColor];

- if ([link length] != 0) {

- [self addLinkRange:NSMakeRange(linkOffset, [link length])

- withName:@""

- linkColor:linkColor];

- }

- (void)setMessage:(NSString*)message

withFont:(NSFont*)font

messageColor:(NSColor*)messageColor {