Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 887583004: [memory-inspector] Add prebuilts for Android x86/x86_64 (Closed)

Created:
5 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
petrcermak
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[memory-inspector] Add prebuilts for Android x86/x86_64 This change also: - adds x86/x86_64 in the list of supported ABIs. - adjusts the regexp of the REST endpoints to support the emulator: the old regex was using \w+ to match the device serial, which doesn't work with the cases such as "emulator-1234". TBR=primiano@chromium.org BUG= Committed: https://crrev.com/95f711c167157db7ea293571dbbdc5fa472f8868 Cr-Commit-Position: refs/heads/master@{#314396}

Patch Set 1 #

Patch Set 2 : Bump manifest #

Total comments: 4

Patch Set 3 : Address review comments #

Messages

Total messages: 12 (4 generated)
Primiano Tucci (use gerrit)
Small fix for our x86 customers. Can you PTAL?
5 years, 10 months ago (2015-02-03 15:47:33 UTC) #2
petrcermak
LGTM % two not-so-important comments :-) https://codereview.chromium.org/887583004/diff/20001/tools/memory_inspector/memory_inspector/frontends/www_server.py File tools/memory_inspector/memory_inspector/frontends/www_server.py (right): https://codereview.chromium.org/887583004/diff/20001/tools/memory_inspector/memory_inspector/frontends/www_server.py#newcode161 tools/memory_inspector/memory_inspector/frontends/www_server.py:161: @AjaxHandler('/ajax/initialize/([^/]+)/([\w-]+)$', 'POST') Any ...
5 years, 10 months ago (2015-02-03 18:21:12 UTC) #3
Primiano Tucci (use gerrit)
https://codereview.chromium.org/887583004/diff/20001/tools/memory_inspector/memory_inspector/frontends/www_server.py File tools/memory_inspector/memory_inspector/frontends/www_server.py (right): https://codereview.chromium.org/887583004/diff/20001/tools/memory_inspector/memory_inspector/frontends/www_server.py#newcode161 tools/memory_inspector/memory_inspector/frontends/www_server.py:161: @AjaxHandler('/ajax/initialize/([^/]+)/([\w-]+)$', 'POST') On 2015/02/03 18:21:12, petrcermak wrote: > Any ...
5 years, 10 months ago (2015-02-03 19:38:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887583004/40001
5 years, 10 months ago (2015-02-03 19:38:53 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-03 19:38:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887583004/40001
5 years, 10 months ago (2015-02-03 19:41:20 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-03 20:17:25 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 20:18:36 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95f711c167157db7ea293571dbbdc5fa472f8868
Cr-Commit-Position: refs/heads/master@{#314396}

Powered by Google App Engine
This is Rietveld 408576698