tools/memory_inspector/memory_inspector/backends/android_backend.py - Issue 887583004: [memory-inspector] Add prebuilts for Android x86/x86_64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/memory_inspector/memory_inspector/backends/android_backend.py

Issue 887583004: [memory-inspector] Add prebuilts for Android x86/x86_64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/memory_inspector/chrome_app/template/manifest.json ('k') | tools/memory_inspector/memory_inspector/frontends/www_server.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/memory_inspector/memory_inspector/backends/android_backend.py

diff --git a/tools/memory_inspector/memory_inspector/backends/android_backend.py b/tools/memory_inspector/memory_inspector/backends/android_backend.py

index 2c4ce7cd7893ae8775e489d863783978283e1e6b..b804805331d77cfc15086854f01b5e025f48c712 100644

--- a/tools/memory_inspector/memory_inspector/backends/android_backend.py

+++ b/tools/memory_inspector/memory_inspector/backends/android_backend.py

@@ -27,8 +27,8 @@ from memory_inspector.core import native_heap

from memory_inspector.core import symbol

-_SUPPORTED_32BIT_ABIS = {'armeabi': 'arm', 'armeabi-v7a': 'arm'}

-_SUPPORTED_64BIT_ABIS = {'arm64-v8a': 'arm64'}

+_SUPPORTED_32BIT_ABIS = {'armeabi': 'arm', 'armeabi-v7a': 'arm', 'x86': 'x86'}

+_SUPPORTED_64BIT_ABIS = {'arm64-v8a': 'arm64', 'x86_64': 'x86_64'}

_MEMDUMP_PREBUILT_PATH = os.path.join(constants.PREBUILTS_PATH,

'memdump-android-%(arch)s')

_MEMDUMP_PATH_ON_DEVICE = '/data/local/tmp/memdump'