Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 887243004: Remove redundant current value checks (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 9 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove redundant current value checks These checks are not needed since parseValue already checks this. BUG=404023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191966

Patch Set 1 #

Patch Set 2 : Remove unrelated change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M Source/core/css/parser/CSSPropertyParser.cpp View 1 6 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 9 months ago (2015-03-16 23:01:55 UTC) #2
Timothy Loh
lgtm
5 years, 9 months ago (2015-03-16 23:09:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/887243004/20001
5 years, 9 months ago (2015-03-16 23:13:17 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 02:02:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191966

Powered by Google App Engine
This is Rietveld 408576698