Remove redundant current value checks

Source/core/css/parser/CSSPropertyParser.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
@@ skipping 2063 matching lines @@
 
 // auto | <identifier>
 bool CSSPropertyParser::parsePage(CSSPropertyID propId, bool important)
 {
     ASSERT(propId == CSSPropertyPage);
 
     if (m_valueList->size() != 1)
         return false;
 
     CSSParserValue* value = m_valueList->current();
-    if (!value)
-        return false;
+    ASSERT(value);
 
     if (value->id == CSSValueAuto) {
         addProperty(propId, cssValuePool().createIdentifierValue(value->id), important);
         return true;
     } else if (value->id == 0 && value->unit == CSSPrimitiveValue::CSS_IDENT) {
         addProperty(propId, createPrimitiveStringValue(value), important);
         return true;
     }
     return false;
 }
 
 // <length>{1,2} | auto | [ <page-size> || [ portrait | landscape] ]
 bool CSSPropertyParser::parseSize(CSSPropertyID propId, bool important)
 {
     ASSERT(propId == CSSPropertySize);
 
     if (m_valueList->size() > 2)
         return false;
 
     CSSParserValue* value = m_valueList->current();
-    if (!value)
-        return false;
+    ASSERT(value);
 
     RefPtrWillBeRawPtr<CSSValueList> parsedValues = CSSValueList::createSpaceSeparated();
 
     // First parameter.
     SizeParameterType paramType = parseSizeParameter(parsedValues.get(), value, None);
     if (paramType == None)
         return false;
 
     // Second parameter, if any.
     value = m_valueList->next();
@@ skipping 1995 matching lines @@
     return id == CSSValueStart || id == CSSValueEnd || id == CSSValueCenter
         || id == CSSValueSelfStart || id == CSSValueSelfEnd || id == CSSValueFlexStart
         || id == CSSValueFlexEnd || id == CSSValueLeft || id == CSSValueRight;
 }
 
 bool CSSPropertyParser::parseLegacyPosition(CSSPropertyID propId, bool important)
 {
     // [ legacy && [ left | right | center ]
 
     CSSParserValue* value = m_valueList->current();
-    if (!value)
-        return false;
+    ASSERT(value);
 
     if (value->id == CSSValueLegacy) {
         value = m_valueList->next();
         if (!value)
             return false;
         if (value->id != CSSValueCenter && value->id != CSSValueLeft && value->id != CSSValueRight)
             return false;
     } else if (value->id == CSSValueCenter || value->id == CSSValueLeft || value->id == CSSValueRight) {
         if (!m_valueList->next() || m_valueList->current()->id != CSSValueLegacy)
             return false;
@@ skipping 55 matching lines @@
 }
 
 bool CSSPropertyParser::parseItemPositionOverflowPosition(CSSPropertyID propId, bool important)
 {
     // auto | stretch | <baseline-position> | [<item-position> && <overflow-position>? ]
     // <baseline-position> = baseline | last-baseline;
     // <item-position> = center | start | end | self-start | self-end | flex-start | flex-end | left | right;
     // <overflow-position> = true | safe
 
     CSSParserValue* value = m_valueList->current();
-    if (!value)
-        return false;
+    ASSERT(value);
 
     if (value->id == CSSValueAuto || value->id == CSSValueStretch || isBaselinePositionKeyword(value->id)) {
         if (m_valueList->next())
             return false;
 
         addProperty(propId, cssValuePool().createIdentifierValue(value->id), important);
         return true;
     }
 
     RefPtrWillBeRawPtr<CSSPrimitiveValue> position = nullptr;
@@ skipping 3764 matching lines @@
 }
 
 bool CSSPropertyParser::isSystemColor(int id)
 {
     return (id >= CSSValueActiveborder && id <= CSSValueWindowtext) || id == CSSValueMenu;
 }
 
 bool CSSPropertyParser::parseSVGValue(CSSPropertyID propId, bool important)
 {
     CSSParserValue* value = m_valueList->current();
-    if (!value)
-        return false;
+    ASSERT(value);
 
     CSSValueID id = value->id;
 
     bool validPrimitive = false;
     RefPtrWillBeRawPtr<CSSValue> parsedValue = nullptr;
 
     switch (propId) {
     /* The comment to the right defines all valid value of these
      * properties as defined in SVG 1.1, Appendix N. Property index */
     case CSSPropertyAlignmentBaseline:
@@ skipping 268 matching lines @@
     return ret.release();
 }
 
 // normal | [ fill || stroke || markers ]
 PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::parsePaintOrder() const
 {
     if (m_valueList->size() > 3)
         return nullptr;
 
     CSSParserValue* value = m_valueList->current();
-    if (!value)
-        return nullptr;
+    ASSERT(value);
 
     RefPtrWillBeRawPtr<CSSValueList> parsedValues = CSSValueList::createSpaceSeparated();
 
     // The default paint-order is: Fill, Stroke, Markers.
     bool seenFill = false, seenStroke = false, seenMarkers = false;
 
     for (; value; value = m_valueList->next()) {
         switch (value->id) {
         case CSSValueNormal:
             // normal inside [fill || stroke || markers] not valid
@@ skipping 290 matching lines @@
         }
     }
 
     if (!list->length())
         return nullptr;
 
     return list.release();
 }
 
 } // namespace blink