Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 887073007: [arm] Assembler support for internal references. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Assembler support for internal references. BUG=v8:3872 LOG=n R=verwaest@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/49cbe537e715c960fb9773af2e240133726f465b Committed: https://crrev.com/5d72955afc7e4f635ae6611e090a63f5a6665dea Cr-Commit-Position: refs/heads/master@{#26476}

Patch Set 1 #

Patch Set 2 : Use different bit pattern #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -23 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 5 chunks +74 lines, -23 lines 0 comments Download
M src/arm/constants-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +166 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-06 05:45:03 UTC) #2
Toon Verwaest
lgtm. A comment about the encoding would be nice though.
5 years, 10 months ago (2015-02-06 07:14:24 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/49cbe537e715c960fb9773af2e240133726f465b Cr-Commit-Position: refs/heads/master@{#26475}
5 years, 10 months ago (2015-02-06 07:21:31 UTC) #5
Benedikt Meurer
Committed patchset #1 (id:1) manually as 49cbe537e715c960fb9773af2e240133726f465b (presubmit successful).
5 years, 10 months ago (2015-02-06 07:21:31 UTC) #6
Benedikt Meurer
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/868803010/ by bmeurer@chromium.org. ...
5 years, 10 months ago (2015-02-06 07:35:52 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5d72955afc7e4f635ae6611e090a63f5a6665dea Cr-Commit-Position: refs/heads/master@{#26476}
5 years, 10 months ago (2015-02-06 07:39:57 UTC) #9
Benedikt Meurer
Committed patchset #2 (id:20001) manually as 5d72955afc7e4f635ae6611e090a63f5a6665dea (tree was closed).
5 years, 10 months ago (2015-02-06 07:39:58 UTC) #10
Benedikt Meurer
5 years, 10 months ago (2015-02-06 07:41:13 UTC) #11
Message was sent while issue was closed.
Ups, that was not intended to be relanded this way... sorry for the confusion.
The second version just fixes the bit pattern.

Powered by Google App Engine
This is Rietveld 408576698